Skip to content

[release/2.8][ROCm][inductor] Improved fast_tanh code generation #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2025
Merged

[release/2.8][ROCm][inductor] Improved fast_tanh code generation #2803

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78f604a
On ROCm, always use fast_tanhf for triton codegen.
naromero77amd Nov 12, 2025
084d7b3
Bump up Triton commit to support fast_tanhf.
naromero77amd Nov 13, 2025
7cc238e
Conditionalize fast_tanhf on triton_version.
naromero77amd Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/triton.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
21876a4bbaf371bcb83df8e6ee4f43a92f524dfe
0cace8d2336a9dc399effbb11522eea7f7b8c0b2
7 changes: 6 additions & 1 deletion torch/_inductor/codegen/triton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,7 +1232,12 @@ def tan(x):
@staticmethod
@maybe_upcast_float32()
def tanh(x):
return f"libdevice.fast_tanhf({x})"
# On ROCm, always use fast_tanhf
# Requires ROCm fork of Triton 3.3, 3.4, 3.5 or upstream Triton 3.6+
if torch.version.hip:
return f"libdevice.fast_tanhf({x})"
else:
return f"libdevice.tanh({x})"

@staticmethod
@maybe_upcast_float32()
Expand Down