Hotfix : Add a note about thread oversubscription in AOCL #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a note about thread oversubscription in AOCL * Apply suggestions from code review Co-authored-by: Jeffrey Novotny <[email protected]>
rkamd
requested review from
a team,
NaveenElumalaiAMD,
TorreZuk,
amcamd,
bragadeesh,
daineAMD and
mahmoodw
as code owners
TorreZuk
approved these changes
Aug 29, 2024
Contributor
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
Minor clarification requested
docs/how-to/Programmers_Guide.rst
Outdated
| These three clients can be built by following the instructions in the Building and Installing section of the User Guide. After building the rocBLAS clients, they can be found in the directory ``rocBLAS/build/release/clients/staging``. | ||
|
|
||
| .. note:: | ||
| The ``rocblas-bench`` and ``rocblas-test`` executables use AMD's ILP64 version of AOCL-BLAS 4.2 as the host reference BLAS to verify correctness. However, there is a known issue with AOCL-BLAS that can cause these executables to hang. This problem can arise because the AOCL-BLAS library launches multiple threads to perform computations. If the number of threads matches the total number of CPU threads, it can lead to thread oversubscription, causing the program to hang. |
Contributor
There was a problem hiding this comment.
Sorry missed this earlier "total number of CPU threads" -> "total number of CPU logical cores"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # SWDEV-481179
Add a note in rocBLAS documentation about thread oversubscription in AOCL
References:
flame/blis#588
flame/blis#604
flame/blis#630