DRAFT: Resolve TFlops=NaN for test attn bug #2004
Draft
+755
−464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez0
reviewed
Sep 30, 2025
There was a problem hiding this comment.
it's hard to figure out the changes, please can you separate it into two commits temporarily? so that we don't see the reformat changes.
|
Important This PR is still draft - please don't spend time reviewing it since now the only things that are added are some DEBUG related lines. (When the PR is ready for review (with a fix) I'll undo the formatting changes so that real changes are easy to be tracked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves https://github.com/ROCm/rocMLIR-internal/issues/1908
Technical Details
Test Plan
Test Result
Submission Checklist