[EXTERNAL] si-fold-operand selecting srcidx for v_mov_b16_t16_e64 #2019
+20
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for reviewers: this is still yet to go in to upstream, so there may be some additional changes. I opened up this PR early so that we could get ahead on some testing. |
umangyadav
reviewed
Oct 8, 2025
| SubDef && TII.isFoldableCopy(*SubDef); | ||
| SubDef = MRI.getVRegDef(Sub->getReg())) { | ||
| unsigned SrcIdx = TII.getFoldableCopySrcIdx(*SubDef); | ||
| const int SrcIdx = |
There was a problem hiding this comment.
Do we have any tests that fail without this fix ?
Upstream doens't have seem to have any UT either.
There was a problem hiding this comment.
None of our tests are affected by this. The upstream PR mentions that this fixes a failing case, so I would imagine the lack of a LIT test is what's keeping it from being merged right now
dhernandez0
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After we pulled llvm/llvm-project#161764 in from upstream to address a failure in the MIGraphX CI, there was some follow up work for the backend failure.
This PR pulls down these changes as well:
llvm/llvm-project#162101
Technical Details
See the upstream PR for full details of the change
Test Plan
Test Result
Submission Checklist