[rocSPARSE] sync before hipFree. (#1705)#1726
Merged
vamovsik merged 3 commits intoROCm:release/rocm-rel-7.0from Sep 26, 2025
Merged
[rocSPARSE] sync before hipFree. (#1705)#1726vamovsik merged 3 commits intoROCm:release/rocm-rel-7.0from
vamovsik merged 3 commits intoROCm:release/rocm-rel-7.0from
Conversation
Since HIP 7.0 `hipFree` is not implicitly blocking as before (see https://rocm.docs.amd.com/projects/HIP/en/latest/hip-7-changes.html#update-hipfree ). Specifically if we allocate using `hipMallocAsync` and then try to free using `hipFree`, the `hipFree` will not be blocking. This means that in the cases where we allocate using `hipMallocAsync` and then free using `hipFree` (for example when the stream is not available for the free), we need to do an explicit synchronization. This PR adds required synchronization points. This PR also reverts ROCm#1609 as it is not required anymore.
kliegeois
requested review from
YvanMokwinski,
jsandham and
ntrost57
as code owners
ntrost57
approved these changes
Sep 24, 2025
jsandham
approved these changes
Sep 24, 2025
coverage target no longer generates html
ntrost57
approved these changes
Sep 25, 2025
assistant-librarian bot
pushed a commit
to ROCm/rocSPARSE
that referenced
this pull request
Sep 26, 2025
[rocSPARSE] sync before hipFree. (#1705) Propagate #1705 to 7.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate #1705 to 7.0.