Skip to content

Conversation

@evetsso
Copy link
Contributor

@evetsso evetsso commented Jan 6, 2026

Motivation

Fix callback tests on MPI transforms, when not all ranks need the same number of callback pointers.

Technical Details

Tests try to assert that the correct number of callback pointers are passed to the execution info. With MPI transforms, this assertion was counting bricks on all ranks rather than just the current rank.

When the tests set callbacks on an MPI transform, they also need to only look at the current rank when deciding how many callback pointers to add to the execution info.

Similarly, when rocFFT builds up its own internal map of device IDs to callback pointers, it also needs to look at the current rank.

Test Plan

Ran MPI tests with callbacks enabled, both without --ngpus and with --ngpus 1. Also ran single-proc multi-device tests with callbacks enabled.

Test Result

Tests pass.

Submission Checklist

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/rocfft/shared/rocfft_params.h 0.00% 11 Missing ⚠️
projects/rocfft/library/src/callback_map.cpp 71.43% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (50.75%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3663      +/-   ##
===========================================
- Coverage    53.70%   51.05%   -2.65%     
===========================================
  Files          120      134      +14     
  Lines        29511    33486    +3975     
  Branches      3804     4403     +599     
===========================================
+ Hits         15848    17096    +1248     
- Misses       12664    15153    +2489     
- Partials       999     1237     +238     
Flag Coverage Δ
hipFFT 53.34% <ø> (?)
rocFFT 50.75% <31.58%> (-2.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
projects/rocfft/library/src/transform.cpp 35.86% <100.00%> (-1.57%) ⬇️
projects/rocfft/library/src/callback_map.cpp 29.76% <71.43%> (+10.25%) ⬆️
projects/rocfft/shared/rocfft_params.h 1.48% <0.00%> (-0.02%) ⬇️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants