[hipDNN] Fix invalid exported include paths and remove old check cmake targets. #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMiservaAMD
changed the title
CMiservaAMD
changed the title
…ndencies (#3685) ## Motivation Resolves ROCm/TheRock#2807 ## Technical Details Issue was due to TheRock install propagating build paths for installed targets. This fix removes the propagated build paths, and adds the proper include paths to the installed cmake config. ## Test Plan Tests & build are passing correctly. Adding a test to TheRock as a separate follow-up to emulate client consumption of hipDNN to prevent regressions. Locally installing the artifacts, and using them to build samples from hipDNN. ## Test Result Test & build are working. Samples are now building and installing properly using artifacts generated with this change.
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
Looks good to me.
Just going to do some local testing of the targets before approving.
BrianHarrisonAMD
approved these changes
Jan 8, 2026
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
Targets looking good from local tests, and changes LGTM.
Thanks!
CMiservaAMD
deleted the
users/cmiserva/ALMIOPEN-836/remove-check-old-cmake-targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves ROCm/TheRock#2807
Also removes the unneeded cmake *check-old test targets as the new ctest targets have proven sufficient.
Technical Details
Issue was due to TheRock install propagating build paths for installed
targets.
This fix removes the propagated build paths, and adds the proper include
paths to the installed cmake config.
Test Plan
Tests & build are passing correctly.
Adding a test to TheRock as a separate follow-up to emulate client
consumption of hipDNN to prevent regressions.
Locally installing the artifacts, and using them to build samples from hipDNN.
Test Result
Test & build are working.
Samples are now building and installing properly using artifacts generated with this change.
ALMIOPEN-836