-
Notifications
You must be signed in to change notification settings - Fork 186
[hipDNN] Move MIOpen plugin to match build normalization RFC from TheRock #3671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adickin-amd
reviewed
Jan 6, 2026
adickin-amd
reviewed
Jan 6, 2026
CMiservaAMD
approved these changes
Jan 6, 2026
Contributor
CMiservaAMD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully the symlink works.
mousdahl-amd
approved these changes
Jan 7, 2026
mattwill-amd
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move and rename MIOpen plugin to match build normalization document from TheRock (RFC0003).
Added a symlink temporarily to keep CI working as we transition this project.
This work will require updating the submodule in TheRock, swapping the build & install over to the new location instead, and then removing the symlink once everything has propagated between repos.
Related to #2316 (needs a few changes to be considered done though).
Technical Details
Test Plan
Tests run and build same as before.
Standalone miopen-provider builds and tests run same as before.
Test Result
Passing build & tests.