Open
Conversation
AviralGoelAMD
approved these changes
Feb 23, 2026
ecamartins
reviewed
Feb 23, 2026
projects/composablekernel/test/ck_tile/gemm_streamk/test_streamk_tile_partitioner_common.hpp
Outdated
Show resolved
Hide resolved
cgmillette
reviewed
Feb 23, 2026
projects/composablekernel/test/ck_tile/gemm_streamk/test_streamk_tile_partitioner_common.hpp
Outdated
Show resolved
Hide resolved
arai713
force-pushed
the
ck/arai/ck_tile/grid_size_rename
branch
from
1029482 to
946af83
Compare
ecamartins
reviewed
Feb 24, 2026
...lekernel/include/ck_tile/ops/gemm/kernel/streamk_gemm/streamk_gemm_tile_partitioner_impl.hpp
Outdated
Show resolved
Hide resolved
arai713
force-pushed
the
ck/arai/ck_tile/grid_size_rename
branch
3 times, most recently
from
7796133 to
5612f49
Compare
arai713
force-pushed
the
ck/arai/ck_tile/grid_size_rename
branch
5 times, most recently
from
5d4df2b to
dc14f61
Compare
github-actions
bot
added
project: hipcub
project: hipfft
project: hiprand
project: hipsolver
project: hipsparse
project: hipsparselt
project: rocblas
project: rocfft
project: rocprim
project: rocrand
project: rocsolver
project: rocsparse
project: rocthrust
shared: rocroller
github actions
shared: origami
project: hipdnn
project: rocwmma
project: hiptensor
project: miopen-provider
ci:hipsparselt-fast
labels
arai713
force-pushed
the
ck/arai/ck_tile/grid_size_rename
branch
from
229035a to
6a3a357
Compare
perfci run on commit 229035a |
Contributor
|
Have some build errors in Tile engine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces a change in the name of the get_grid function in the Stream-K TilePartitioner to avoid confusion with a similarly named method. In the Stream-K TilePartitioner, there is get_grid() which returns num_cu*occupancy and there is grid_size() which returns the grid size used to launch the kernel. In this PR, we change get_grid() to be get_max_active_wgs() to better reflect what the function returns and not confuse it with grid_size().
Technical Details
Initially in the Stream-K TilePartitioner we had get_grid() which returned grid_. We are renaming get_grid() to get_max_active_wgs() and grid_ to max_active_wgs_ internally, while keeping grid_size() the same. The parameter, grid, for the Stream-K TilePartitioner remains the same to maintain consistency with the rest of the Stream-K API.
Test Plan
Validated using the test suite that is already present.
Test Result
All tests passed
Submission Checklist