Fix grouped GEMM launch code to derive grid size from filtered kargs#5150
Draft
Fix grouped GEMM launch code to derive grid size from filtered kargs#5150
Conversation
Derive grid size from kargs (which skips groups with M/N/K==0) instead of gemm_descs, ensuring consistency between grid size, hipMemcpy, and kernel launch arguments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
Copilot
AI
changed the title
[WIP] Fix issues in grouped gemm implementation based on feedback
Fix grouped GEMM launch code to derive grid size from filtered kargs
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel::MakeKargs(gemm_descs)skips groups where M/N/K==0, so it can return fewer entries thangemm_descs.size(). The grid size was computed viaKernel::GridSize(gemm_descs)which used the unfiltered count, causing the kernel to be launched over more blocks than there are valid kernel arguments.Changes
Kernel::GridSize(gemm_descs)→dim3(kargs.empty() ? 0 : kargs.back().block_end, 1, 1)— derived from the filteredkargsvector, consistent with howhipMemcpyWithStreamandgroup_countalready usedkargs.size()The
hipMemcpyWithStreambyte count andgroup_countkernel argument were already correctly usingkargs.size().🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.