[hipBLASLt] Fix shard overlay convergence#5354
Open
davidd-amd wants to merge 3 commits intodevelopfrom
Open
Conversation
In TheRock's multi-shard build, each shard builds hipBLASLt for a subset of GPU targets, and all shard install trees are overlaid onto a single filesystem prefix. Three artifacts were last-writer-wins during overlay, causing metadata loss for earlier shards: - hipblasltExtOpLibrary.dat (ExtOp op/kernel metadata) - TensileLiteLibrary_lazy_Mapping (Tensile solution index) - hipblasltTransform.hsaco (matrix-transform fat binary) The fix introduces HIPBLASLT_DIST_TARGETS, a new CMake cache variable representing the full distribution GPU target list. When set by TheRock (e.g. -DHIPBLASLT_DIST_TARGETS="gfx942;gfx1100"), all shards use the same target set for metadata generation, producing byte-for-byte identical artifacts across shards so overlay is safe. HIPBLASLT_DIST_TARGETS defaults to GPU_TARGETS, so standalone builds are unaffected. The host library (libhipblaslt.so) requires no change — GPU_TARGETS has no effect on host compilation flags and the library is already bit-for-bit identical across shards. Changes: - Add HIPBLASLT_DIST_TARGETS cache variable to top-level CMakeLists.txt - Use HIPBLASLT_DIST_TARGETS for TensileCreateLibrary --architecture arg - Use HIPBLASLT_DIST_TARGETS for ExtOp arch loop in extops/CMakeLists.txt - Use HIPBLASLT_DIST_TARGETS for matrix-transform --offload-arch flags Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.23%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5354 +/- ##
===========================================
+ Coverage 66.51% 66.51% +0.01%
===========================================
Files 1791 1791
Lines 277130 276814 -316
Branches 38793 38707 -86
===========================================
- Hits 184310 184120 -190
+ Misses 76836 76730 -106
+ Partials 15984 15964 -20
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
perfci run on commit 5fae749 |
Contributor
Author
|
FYI @stellaraccident |
davidd-amd
commented
Mar 11, 2026
perfci run on commit 927de9d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TheRock's multi-shard build, each shard builds hipBLASLt for a subset of GPU targets, and all shard install trees are overlaid onto a single filesystem prefix. Three artifacts were last-writer-wins during overlay, causing metadata loss for earlier shards:
The fix introduces HIPBLASLT_DIST_TARGETS, a new CMake cache variable representing the full distribution GPU target list. When set by TheRock (e.g. -DHIPBLASLT_DIST_TARGETS="gfx942;gfx1100"), all shards use the same target set for metadata generation, producing byte-for-byte identical artifacts across shards so overlay is safe.
HIPBLASLT_DIST_TARGETS defaults to GPU_TARGETS, so standalone builds are unaffected. The host library (libhipblaslt.so) requires no change — GPU_TARGETS has no effect on host compilation flags and the library is already bit-for-bit identical across shards.
Changes: