Skip to content

Add gfx1150 support and rocBLAS yaml files for gfx1151 (#452)#744

Merged
vamovsik merged 8 commits intorelease/rocm-rel-7.0from
cherry-pick-rocblas-add-gfx1150-rel-7.0
Sep 18, 2025
Merged

Add gfx1150 support and rocBLAS yaml files for gfx1151 (#452)#744
vamovsik merged 8 commits intorelease/rocm-rel-7.0from
cherry-pick-rocblas-add-gfx1150-rel-7.0

Conversation

@amd-mtrifuno
Copy link
Contributor

@amd-mtrifuno amd-mtrifuno commented Jul 18, 2025


🔁 Imported from
ROCm/rocBLAS#1659 🧑‍💻 Originally authored by @amd-mtrifuno


- Adding initial support for gfx1150
- Need to update tensile_tag.txt after PR with Tensile changes is merged #697

---
🔁 Imported from
[ROCm/rocBLAS#1659](ROCm/rocBLAS#1659)
🧑‍💻 Originally authored by @amd-mtrifuno

---------

Co-authored-by: Milica Trifunovic <milica.trifunovic@amd.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
@TorreZuk
Copy link
Contributor

@amd-mtrifuno you should add the tensile_tag for the cherry pick PR commit for now so the builds can pass, but yes after tensile merge the commit needs to change to the merged and pushed back commit to old repo.

@amd-mtrifuno
Copy link
Contributor Author

@amd-mtrifuno you should add the tensile_tag for the cherry pick PR commit for now so the builds can pass, but yes after tensile merge the commit needs to change to the merged and pushed back commit to old repo.

Since tensile_tag is updated on a commit from the ROCm/Tensile repo, and I still don't have a commit on the rocm-rel-7.0 branch there, I'm not sure how to update the tensile_tag. Can you explain to me which commit I should use for now?

@TorreZuk
Copy link
Contributor

TorreZuk commented Jul 18, 2025

Sorry yes you don't have a push back commit so would just have to be develop tip from Tensile that might cover the requirements to get a build.

@TorreZuk
Copy link
Contributor

Maybe try f591f88e48f3e7735d550afbc5970de6a8eb0bd4 tip of old repo Tensile develop. Has both 1150 and 1151

@amd-jnovotny
Copy link
Contributor

@amd-mtrifuno Can you add a rocBLAS CHANGELOG update (to the 6.4.3 section) highlighting that gfx1150 support was added?

@amd-mtrifuno amd-mtrifuno requested a review from a team as a code owner August 25, 2025 12:44
@amd-mtrifuno amd-mtrifuno changed the title Add gfx1150 support (#452) Add gfx1150 support and rocBLAS yaml files for gfx1151 (#452) Aug 25, 2025
@amd-mtrifuno amd-mtrifuno requested a review from a team as a code owner August 25, 2025 12:52
@TorreZuk
Copy link
Contributor

TorreZuk commented Sep 3, 2025

@amd-mtrifuno I think you need a rebase as the cmake code difference looks wrong. Otherwise fine by me if approved for point release.

@amcamd
Copy link
Contributor

amcamd commented Sep 9, 2025

@amd-mtrifuno what is the repository and branch that contains commit 97085038f2d7341dca78469b5e866ab7766790ed from tensile_tag.txt?

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the tensile PR has been merged and the pushback commit exists in old repo tip of release/rocm-rel-7.0 the tensile_tag.txt needs to be that commit. cca3c8136aa812109629e6291ce9f0ca846b68d3 is the pushback of current mono tip for 7.0 branch

@amd-mtrifuno
Copy link
Contributor Author

@amd-mtrifuno what is the repository and branch that contains commit 97085038f2d7341dca78469b5e866ab7766790ed from tensile_tag.txt?

I created branch on old Tensile repo with exactly the same changes as the PR for the monorepo just for testing purposes. Once the Tensile PR has been merged, I will update the tensele_tag.txt file as Torre Zuk explained.

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine if local testing passed

@vamovsik vamovsik merged commit 2dc4f0c into release/rocm-rel-7.0 Sep 18, 2025
9 checks passed
@vamovsik vamovsik deleted the cherry-pick-rocblas-add-gfx1150-rel-7.0 branch September 18, 2025 18:39
assistant-librarian bot pushed a commit to ROCm/rocBLAS that referenced this pull request Sep 18, 2025
Add gfx1150 support and rocBLAS yaml files for gfx1151
 (#744)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Adding initial support for gfx1150
- Add Strix Halo yaml files that are copy of Navi33 yaml files (the same
changes added for Strix Point)
- Need to update tensile_tag.txt after PR with Tensile changes is merged
ROCm/rocm-libraries#697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants