Updating Runners for ROCProfiler#12
Merged
ammarwa merged 2 commits intoamd/hsivasun/modify-workflowsfrom Jul 30, 2025
Merged
Conversation
ammarwa
merged commit 12ab109
into
amd/hsivasun/modify-workflows
25 of 63 checks passed
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
1) When `clang` is used as system compiler, libraries were built without respecting LDFLAGS. For example, this affected LTO flags, if any (and it only affected clang, not gcc). 2) Linker flags are registered as CXX flags, which produces warnings during compilation: ``` clang++: warning: -Wl,-z,noexecstack: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-znoexecheap: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,relro: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,now: 'linker' input unused [-Wunused-command-line-argument] ``` 3) Clang does not support `-Wtrampolines` flag: ``` warning: unknown warning option '-Wtrampolines' [-Wunknown-warning-option] ``` 4) No linkers support `noexecheap` anymore. `noexecheap` linker flag was a part of PaX patches to GNU ld, (which were dropped in 2017)[https://www.gentoo.org/support/news-items/2017-08-19-hardened-sources-removal.html]. Now ld/ld.lld/ld.gold don't support it and protection of heap is managed by NX bit. Therefore every compiler produces this warning: ``` ld.lld: warning: unknown -z value: noexecheap ``` Closes #210. Co-authored-by: Sv. Lockal <lockalsash@gmail.com>
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
1) When `clang` is used as system compiler, libraries were built without respecting LDFLAGS. For example, this affected LTO flags, if any (and it only affected clang, not gcc). 2) Linker flags are registered as CXX flags, which produces warnings during compilation: ``` clang++: warning: -Wl,-z,noexecstack: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-znoexecheap: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,relro: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,now: 'linker' input unused [-Wunused-command-line-argument] ``` 3) Clang does not support `-Wtrampolines` flag: ``` warning: unknown warning option '-Wtrampolines' [-Wunknown-warning-option] ``` 4) No linkers support `noexecheap` anymore. `noexecheap` linker flag was a part of PaX patches to GNU ld, (which were dropped in 2017)[https://www.gentoo.org/support/news-items/2017-08-19-hardened-sources-removal.html]. Now ld/ld.lld/ld.gold don't support it and protection of heap is managed by NX bit. Therefore every compiler produces this warning: ``` ld.lld: warning: unknown -z value: noexecheap ``` Closes #210. Co-authored-by: Sv. Lockal <lockalsash@gmail.com>
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 5, 2025
[ROCm/rocprofiler commit: 1fcb951]
ammallya
pushed a commit
that referenced
this pull request
Aug 6, 2025
#12) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.2 to 1.8.3. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.8.2...v1.8.3) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocprofiler-systems commit: 1e5f7f6]
ammallya
pushed a commit
that referenced
this pull request
Aug 6, 2025
#12) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.2 to 1.8.3. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.8.2...v1.8.3) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocprofiler-systems commit: 83451e0]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 8, 2025
1) When `clang` is used as system compiler, libraries were built without respecting LDFLAGS. For example, this affected LTO flags, if any (and it only affected clang, not gcc). 2) Linker flags are registered as CXX flags, which produces warnings during compilation: ``` clang++: warning: -Wl,-z,noexecstack: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-znoexecheap: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,relro: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,now: 'linker' input unused [-Wunused-command-line-argument] ``` 3) Clang does not support `-Wtrampolines` flag: ``` warning: unknown warning option '-Wtrampolines' [-Wunknown-warning-option] ``` 4) No linkers support `noexecheap` anymore. `noexecheap` linker flag was a part of PaX patches to GNU ld, (which were dropped in 2017)[https://www.gentoo.org/support/news-items/2017-08-19-hardened-sources-removal.html]. Now ld/ld.lld/ld.gold don't support it and protection of heap is managed by NX bit. Therefore every compiler produces this warning: ``` ld.lld: warning: unknown -z value: noexecheap ``` Closes #210. Co-authored-by: Sv. Lockal <lockalsash@gmail.com> [ROCm/rocm_smi_lib commit: 4dbc2b6]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 8, 2025
1) When `clang` is used as system compiler, libraries were built without respecting LDFLAGS. For example, this affected LTO flags, if any (and it only affected clang, not gcc). 2) Linker flags are registered as CXX flags, which produces warnings during compilation: ``` clang++: warning: -Wl,-z,noexecstack: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-znoexecheap: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,relro: 'linker' input unused [-Wunused-command-line-argument] clang++: warning: -Wl,-z,now: 'linker' input unused [-Wunused-command-line-argument] ``` 3) Clang does not support `-Wtrampolines` flag: ``` warning: unknown warning option '-Wtrampolines' [-Wunknown-warning-option] ``` 4) No linkers support `noexecheap` anymore. `noexecheap` linker flag was a part of PaX patches to GNU ld, (which were dropped in 2017)[https://www.gentoo.org/support/news-items/2017-08-19-hardened-sources-removal.html]. Now ld/ld.lld/ld.gold don't support it and protection of heap is managed by NX bit. Therefore every compiler produces this warning: ``` ld.lld: warning: unknown -z value: noexecheap ``` Closes #210. Co-authored-by: Sv. Lockal <lockalsash@gmail.com> [ROCm/rocm_smi_lib commit: 59cbeb5]
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 10, 2025
Initial draft of PR template
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Add palamida.yml - removing url [ROCm/rocminfo commit: eb62039]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 11, 2025
[ROCm/rocm-core commit: 0578cf7]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
Initial draft of PR template [ROCm/hipother commit: 0e51a3b]
1 task
jeffqjiangNew
added a commit
that referenced
this pull request
Mar 13, 2026
## Motivation This PR adds entry and exit logs for core functions. ## Technical Details - Info level (3) logs are added at core function entry and exit points. - Monotonic clock stamp, process id, thread id, and file name are added to the logs. - The logs now have similar format to HIP logs for better viewing when both are present. - Direct error or warning logs to std::cerr. Other logs still go to std::cout. ## JIRA ID <!-- If applicable, mention the JIRA ID resolved by this PR (Example: Resolves SWDEV-12345). --> <!-- Do not post any JIRA links here. --> ## Test Plan Set env variable ROCDEC_LOG_LEVEL to control log output. All CTests and conformance tests must pass. Example summary of the test results: - CTests: Start 1: video_decodeRaw-HEVC 1/15 Test #1: video_decodeRaw-HEVC ............. Passed 2.05 sec Start 2: video_decodeRaw-AVC 2/15 Test #2: video_decodeRaw-AVC .............. Passed 1.89 sec Start 3: video_decodeRaw-AV1 3/15 Test #3: video_decodeRaw-AV1 .............. Passed 2.31 sec Start 4: video_decodeRaw-VP9 4/15 Test #4: video_decodeRaw-VP9 .............. Passed 2.04 sec Start 5: rocdec_Decode-HEVC 5/15 Test #5: rocdec_Decode-HEVC ............... Passed 0.92 sec Start 6: rocDecode_Negative_API_Tests 6/15 Test #6: rocDecode_Negative_API_Tests ..... Passed 0.78 sec Start 7: video_decode-HEVC 7/15 Test #7: video_decode-HEVC ................ Passed 2.74 sec Start 8: video_decode-AVC 8/15 Test #8: video_decode-AVC ................. Passed 2.64 sec Start 9: video_decode-AV1 9/15 Test #9: video_decode-AV1 ................. Passed 2.74 sec Start 10: video_decode-VP9 10/15 Test #10: video_decode-VP9 ................. Passed 2.78 sec Start 11: video_decodePerf-HEVC 11/15 Test #11: video_decodePerf-HEVC ............ Passed 2.92 sec Start 12: video_decodeBatch 12/15 Test #12: video_decodeBatch ................ Passed 4.34 sec Start 13: video_decodeRGB-HEVC 13/15 Test #13: video_decodeRGB-HEVC ............. Passed 33.51 sec Start 14: video_decodeMem-HEVC 14/15 Test #14: video_decodeMem-HEVC ............. Passed 2.09 sec Start 15: video_decodeRGB-Resize 15/15 Test #15: video_decodeRGB-Resize ........... Passed 33.94 sec 100% tests passed, 0 tests failed out of 15 - AVC conformance test: Conformance test completed on the 127 streams: - The number of passing streams is 127 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - HEVC conformance test: Conformance test completed on the 135 streams: - The number of passing streams is 135 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - AV1 conformance test: Conformance test completed on the 162 streams: - The number of passing streams is 162 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - VP9 conformance test: Conformance test completed on the 108 streams: - The number of passing streams is 108 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 ## Test Result Function entry/exit logs should show up when ROCDEC_LOG_LEVEL >= 3. All conformance tests should pass. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Nikhil-Nunna
pushed a commit
that referenced
this pull request
Mar 13, 2026
## Motivation This PR adds entry and exit logs for core functions. ## Technical Details - Info level (3) logs are added at core function entry and exit points. - Monotonic clock stamp, process id, thread id, and file name are added to the logs. - The logs now have similar format to HIP logs for better viewing when both are present. - Direct error or warning logs to std::cerr. Other logs still go to std::cout. ## JIRA ID <!-- If applicable, mention the JIRA ID resolved by this PR (Example: Resolves SWDEV-12345). --> <!-- Do not post any JIRA links here. --> ## Test Plan Set env variable ROCDEC_LOG_LEVEL to control log output. All CTests and conformance tests must pass. Example summary of the test results: - CTests: Start 1: video_decodeRaw-HEVC 1/15 Test #1: video_decodeRaw-HEVC ............. Passed 2.05 sec Start 2: video_decodeRaw-AVC 2/15 Test #2: video_decodeRaw-AVC .............. Passed 1.89 sec Start 3: video_decodeRaw-AV1 3/15 Test #3: video_decodeRaw-AV1 .............. Passed 2.31 sec Start 4: video_decodeRaw-VP9 4/15 Test #4: video_decodeRaw-VP9 .............. Passed 2.04 sec Start 5: rocdec_Decode-HEVC 5/15 Test #5: rocdec_Decode-HEVC ............... Passed 0.92 sec Start 6: rocDecode_Negative_API_Tests 6/15 Test #6: rocDecode_Negative_API_Tests ..... Passed 0.78 sec Start 7: video_decode-HEVC 7/15 Test #7: video_decode-HEVC ................ Passed 2.74 sec Start 8: video_decode-AVC 8/15 Test #8: video_decode-AVC ................. Passed 2.64 sec Start 9: video_decode-AV1 9/15 Test #9: video_decode-AV1 ................. Passed 2.74 sec Start 10: video_decode-VP9 10/15 Test #10: video_decode-VP9 ................. Passed 2.78 sec Start 11: video_decodePerf-HEVC 11/15 Test #11: video_decodePerf-HEVC ............ Passed 2.92 sec Start 12: video_decodeBatch 12/15 Test #12: video_decodeBatch ................ Passed 4.34 sec Start 13: video_decodeRGB-HEVC 13/15 Test #13: video_decodeRGB-HEVC ............. Passed 33.51 sec Start 14: video_decodeMem-HEVC 14/15 Test #14: video_decodeMem-HEVC ............. Passed 2.09 sec Start 15: video_decodeRGB-Resize 15/15 Test #15: video_decodeRGB-Resize ........... Passed 33.94 sec 100% tests passed, 0 tests failed out of 15 - AVC conformance test: Conformance test completed on the 127 streams: - The number of passing streams is 127 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - HEVC conformance test: Conformance test completed on the 135 streams: - The number of passing streams is 135 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - AV1 conformance test: Conformance test completed on the 162 streams: - The number of passing streams is 162 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - VP9 conformance test: Conformance test completed on the 108 streams: - The number of passing streams is 108 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 ## Test Result Function entry/exit logs should show up when ROCDEC_LOG_LEVEL >= 3. All conformance tests should pass. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.