Extend the hack to propagate HIP usage requirements a bit further. by systems-assistant[bot] · Pull Request #147 · ROCm/rocm-systems

systems-assistant · 2025-08-07T18:38:18Z

PR Details

Associated Jira Ticket Number/Link

Patch coming from TheRock: ROCm/TheRock#302

What type of PR is this? (check all applicable)

Technical details

Also fetches usage requirements from hip::amdhip64 -> rocprofiler-sdk-hip-nolink
Adds rocprofiler-sdk-hip-nolink as a dependency of two libraries that indirectly depend on hip headers via hip.h.
The above may not be completely as precise as it can be (it seems like there should be an intermediate library for this of some kind).
Also conditions the link of hsa-amd-aqlprofile64_library on whether the library was found, which however might not be correct.

Added/updated tests?

Yes
No, Does not apply to this PR.

Updated CHANGELOG?

Yes
No, Does not apply to this PR.

Added/Updated documentation?

Yes
No, Does not apply to this PR.

🔁 Imported from ROCm/rocprofiler-sdk#65
🧑‍💻 Originally authored by @taylding-amd

…evelop/taylding-amd_rocprofiler-sdk/the_rock_patch_3

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-sdk commit: 34145fa]

* Reapply "Upgrade ROCm-SMI to AMD SMI (ROCm#86)" This reverts commit 9fcea73. --------- Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> Co-authored-by: David Galiffi <David.Galiffi@amd.com> [ROCm/rocprofiler-systems commit: 85bbea4]

jrmadsen · 2025-09-02T15:48:11Z

projects/rocprofiler-sdk/source/lib/common/container/CMakeLists.txt


 target_sources(rocprofiler-sdk-common-library PRIVATE ${containers_sources}
                                                      ${containers_headers})
+target_link_libraries(rocprofiler-sdk-common-library PRIVATE rocprofiler-sdk-hip-nolink)


I do not see why this is necessary. There are no headers included in the common library which rely on HIP that I can see.

Seems it is not needed. Addressed and removed this in #1086.

jrmadsen · 2025-09-02T15:49:56Z

projects/rocprofiler-sdk/source/lib/output/CMakeLists.txt

            rocprofiler-sdk::rocprofiler-sdk-cereal
            rocprofiler-sdk::rocprofiler-sdk-perfetto
            rocprofiler-sdk::rocprofiler-sdk-otf2
+	    rocprofiler-sdk-hip-nolink


This needs to be formatted and you need to use the namespaced target.

Addressed in #1086.

jrmadsen · 2025-09-02T15:53:27Z

projects/rocprofiler-sdk/cmake/rocprofiler_config_interfaces.cmake

+# TODO: As of 2024/2/12, the hip::host target does not advertise its
+# include directory but amdhip64 does. This ordinarily wouldn't be an issue
+# because most folks just get it transitively, but here this is doing direct
+# property copying to get usage requirements.
+# The proper fix is for hip to export a hip::headers target with only usage
+# requirements and depend on that.


Is hip::host necessary anymore? Are you aware that rocprofiler_config_nolink_target is recursive? It recursively invokes itself for each CMake target linked to the initial target.

hip::host is not needed ad nolink target. Addressed in #1086.

* add API doc comments to goamdsmi.go * update README and usage * add sphinx directive to parse go doc * fix walrus operator typos * make docs more consistent * add Go docs to index.md --------- Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>

* add API doc comments to goamdsmi.go * update README and usage * add sphinx directive to parse go doc * fix walrus operator typos * make docs more consistent * add Go docs to index.md --------- Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com> [ROCm/amdsmi commit: 15c32f6]

[SYNC] NCCL-Tests v2.16.7

[ROCm/rocshmem commit: e0ef34a]

[SYNC] NCCL-Tests v2.16.7 [ROCm/rccl-tests commit: 690f97c]

…inx (#147) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.18.4. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.18.2...v1.18.4) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.18.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…inx (#147) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.18.4. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.18.2...v1.18.4) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.18.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocjpeg commit: dfe2f0f]

stellaraccident and others added 2 commits May 12, 2025 15:13

Extend the hack to propagate HIP usage requirements a bit further.

245b0fa

Merge commit '245b0fa37e5493a22b27f81536dea83896ab5e96' into import/d…

cbc8217

…evelop/taylding-amd_rocprofiler-sdk/the_rock_patch_3

systems-assistant bot added the imported pr label Aug 7, 2025

systems-assistant bot requested review from jrmadsen and t-tye as code owners August 7, 2025 18:38

systems-assistant bot added imported pr project: rocprofiler-sdk labels Aug 7, 2025

jayhawk-commits assigned taylding-amd Aug 7, 2025

jayhawk-commits added the organization: ROCm label Aug 7, 2025

ammallya pushed a commit that referenced this pull request Aug 7, 2025

Upload artifacts only on 'workflow_dispatch' (#147)

3de44de

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-sdk commit: 34145fa]

bwelton assigned jrmadsen Aug 19, 2025

jrmadsen requested changes Sep 2, 2025

View reviewed changes

jrmadsen mentioned this pull request Sep 2, 2025

[rockprofiler-sdk] Extend the hack to propagate HIP usage requirements a bit further ROCm/TheRock#302

Closed

This was referenced Sep 22, 2025

Upstreaming TheRock Patch for rocprofiler-sdk #1056

Closed

Rollup of build changes needed for compat with TheRock. #1086

Merged

jrmadsen closed this Sep 30, 2025

habajpai-amd mentioned this pull request Nov 19, 2025

Fix fork() handling for GPU profiling and AMD SMI #1930

Merged

1 task

jamessiddeley-amd pushed a commit that referenced this pull request Dec 11, 2025

Merge pull request #147 from nileshnegi/sync/nccl-tests_v2.16.7

690f97c

[SYNC] NCCL-Tests v2.16.7

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Fix typo (#147)

e0ef34a

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Fix typo (#147)

229e97a

[ROCm/rocshmem commit: e0ef34a]

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Merge pull request #147 from nileshnegi/sync/nccl-tests_v2.16.7

74b03fe

[SYNC] NCCL-Tests v2.16.7 [ROCm/rccl-tests commit: 690f97c]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend the hack to propagate HIP usage requirements a bit further.#147

Extend the hack to propagate HIP usage requirements a bit further.#147
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
import/develop/taylding-amd_rocprofiler-sdk/the_rock_patch_3

systems-assistant bot commented Aug 7, 2025

Uh oh!

jrmadsen Sep 2, 2025

Uh oh!

marbre Sep 22, 2025

Uh oh!

jrmadsen Sep 2, 2025

Uh oh!

marbre Sep 22, 2025

Uh oh!

jrmadsen Sep 2, 2025

Uh oh!

marbre Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

systems-assistant bot commented Aug 7, 2025

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Updated CHANGELOG?

Added/Updated documentation?

Uh oh!

jrmadsen Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

marbre Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jrmadsen Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

marbre Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jrmadsen Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

marbre Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants