Potential fix for code scanning alert no. 5: Incorrect allocation-error handling#173
Open
systems-assistant[bot] wants to merge 4 commits intodevelopfrom
Open
Potential fix for code scanning alert no. 5: Incorrect allocation-error handling#173systems-assistant[bot] wants to merge 4 commits intodevelopfrom
systems-assistant[bot] wants to merge 4 commits intodevelopfrom
Conversation
…or handling Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…evelop/ROCm_aqlprofile/alert-autofix-5
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
[ROCm/rocprofiler-sdk commit: 075d36e]
ywang103-amd
pushed a commit
to ywang103-amd/rocm-systems
that referenced
this pull request
Aug 7, 2025
Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.1 to 44.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.1...44.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-version: 44.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocprofiler-systems commit: cbc0080]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AMD-ROCm-Internal/aqlprofile/security/code-scanning/5
To fix the issue, the redundant null pointer check after should be removed. Instead, the allocation failure should be handled using a block to catch the exception, which is the standard mechanism for handling allocation errors in C++. This ensures that the code adheres to C++ best practices and avoids misleading constructs.
Detailed steps:
Suggested fixes powered by Copilot Autofix. Review carefully before merging.
🔁 Imported from ROCm/aqlprofile#16
🧑💻 Originally authored by @rocm-devops