Fix ASAN warning for Unit_hipGraphRetainUserObject_Functional_1 #2970
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shadi <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an AddressSanitizer (ASAN) warning in the hipUserObjectRelease function by reordering the conditions in a validation check. The issue was that the code was attempting to access the reference count of a user object before validating that the pointer was valid, which could cause accessing invalid memory and trigger ASAN warnings.
Changes:
- Reordered condition check in
hipUserObjectReleaseto validate pointer before dereferencing it
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shadidashmiz
force-pushed
the
amd/sdashmiz/asanuserobj
branch
from
bfeb9b7 to
419aa29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist