[RDC] [SWDEV-380626] Errors printed are not conveying the right message & adding field ID's after fieldgroup creation fix. #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error reporting in the RDC (ROCm Data Center) library by introducing more specific error codes for group and field group operations, and removes deprecated driver reload functionality from the amdsmi CLI.
Changes:
- Replaced generic
RDC_ST_NOT_FOUNDerrors with specificRDC_ST_GROUP_NOT_FOUNDandRDC_ST_FLDGROUP_NOT_FOUNDerror codes - Added new error status codes to RDC header, C++ implementation, and Python bindings
- Removed deprecated
--reload-driveroption from amdsmi CLI and documented the removal
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/rdc/include/rdc/rdc.h | Defines new error status codes for group and field group not found scenarios |
| projects/rdc/rdc_libs/rdc/src/RdcGroupSettingsImpl.cc | Updates error returns to use specific group/field group error codes |
| projects/rdc/rdc_libs/bootstrap/src/RdcBootStrap.cc | Adds string representations for new error codes |
| projects/rdc/python_binding/rdc_bootstrap.py | Adds Python enum values for new error codes |
| projects/amdsmi/amdsmi_cli/amdsmi_parser.py | Removes deprecated driver reload CLI option |
| projects/amdsmi/CHANGELOG.md | Documents removal of driver reload option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| reset_power_cap_help = "Reset the PPT0 and PPT1 power capacity limit to max capable" | ||
| reset_gpu_clean_local_data_help = "Clean up local data in LDS/GPRs on a per partition basis" | ||
| reset_gpu_driver_help = "Triggers a chain that resets all GPU's" | ||
|
|
There was a problem hiding this comment.
Empty lines should not have trailing whitespace. Remove the whitespace from this line.
| # Add Baremetal and Virtual OS reset arguments | ||
| reset_exclusive_group.add_argument('-l', '--clean-local-data', action='store_true', required=False, help=reset_gpu_clean_local_data_help) | ||
| reset_exclusive_group.add_argument('-r', '--reload-driver', action='store_true', required=False, help=reset_gpu_driver_help) | ||
|
|
There was a problem hiding this comment.
Empty lines should not have trailing whitespace. Remove the whitespace from this line.
Signed-off-by: yalmusaf_amdeng <[email protected]>
yalmusaf
force-pushed
the
SWDEV-380626-NEW
branch
from
42b582a to
6c02df2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RDC error messages are vague as well as when creating fieldgroups you cannot add field ID's later.
Technical Details
changes were made to error code returned in multiple files.
JIRA ID
https://ontrack-internal.amd.com/browse/SWDEV-380626
Test Plan
N/A
Test Result
N/A
Submission Checklist
N/A