[rocprofiler-sdk][rocprofiler-register] add CPackComponent#3499
Merged
ammallya merged 5 commits intoROCm:developfrom Mar 9, 2026
Merged
[rocprofiler-sdk][rocprofiler-register] add CPackComponent#3499ammallya merged 5 commits intoROCm:developfrom
ammallya merged 5 commits intoROCm:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CMake configure-time errors in the rocprofiler-sdk and rocprofiler-register packaging configuration by ensuring the CPack component macros are available before they are used.
Changes:
- Add
include(CPackComponent)to rocprofiler-sdk packaging config before callingcpack_add_component_group(...). - Add
include(CPackComponent)to rocprofiler-register packaging config before callingcpack_add_component_group(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/rocprofiler-sdk/cmake/rocprofiler_config_packaging.cmake | Includes CPackComponent so cpack_add_component_group is defined before use. |
| projects/rocprofiler-register/cmake/rocprofiler_register_config_packaging.cmake | Includes CPackComponent so cpack_add_component_group is defined before use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@ROCm/rocm-devtools-team @ROCm/rocprofiler-owners please review this PR |
bwelton
reviewed
Mar 3, 2026
projects/rocprofiler-sdk/cmake/rocprofiler_config_packaging.cmake
Outdated
Show resolved
Hide resolved
…m-systems into add-cpack-component
bwelton
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change fixes build errors in rocprofiler-register and rocprofiler-sdk with
ROCPROFILER_REGISTER_BUILD_GLOG=OFFandROCPROFILER_BUILD_GLOG=OFF. The following errors can be seen:rocprofiler-sdk
rocprofiler-register
To fix these errors, the statement
include(CPackComponent)has been added to the relevant files where these errors occur.