Skip to content

[rocprofiler-sdk][rocprofiler-register] add CPackComponent#3499

Merged
ammallya merged 5 commits intoROCm:developfrom
afzpatel:add-cpack-component
Mar 9, 2026
Merged

[rocprofiler-sdk][rocprofiler-register] add CPackComponent#3499
ammallya merged 5 commits intoROCm:developfrom
afzpatel:add-cpack-component

Conversation

@afzpatel
Copy link
Contributor

Motivation

This change fixes build errors in rocprofiler-register and rocprofiler-sdk with ROCPROFILER_REGISTER_BUILD_GLOG=OFF and ROCPROFILER_BUILD_GLOG=OFF. The following errors can be seen:

rocprofiler-sdk

CMake Error at cmake/rocprofiler_config_packaging.cmake:134 (cpack_add_component_group):
  Unknown CMake command "cpack_add_component_group".
Call Stack (most recent call first):
  CMakeLists.txt:136 (include)

rocprofiler-register

CMake Error at cmake/rocprofiler_register_config_packaging.cmake:84 (cpack_add_component_group):
  Unknown CMake command "cpack_add_component_group".
Call Stack (most recent call first):
  CMakeLists.txt:116 (include)

To fix these errors, the statement include(CPackComponent) has been added to the relevant files where these errors occur.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CMake configure-time errors in the rocprofiler-sdk and rocprofiler-register packaging configuration by ensuring the CPack component macros are available before they are used.

Changes:

  • Add include(CPackComponent) to rocprofiler-sdk packaging config before calling cpack_add_component_group(...).
  • Add include(CPackComponent) to rocprofiler-register packaging config before calling cpack_add_component_group(...).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
projects/rocprofiler-sdk/cmake/rocprofiler_config_packaging.cmake Includes CPackComponent so cpack_add_component_group is defined before use.
projects/rocprofiler-register/cmake/rocprofiler_register_config_packaging.cmake Includes CPackComponent so cpack_add_component_group is defined before use.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@afzpatel
Copy link
Contributor Author

afzpatel commented Mar 3, 2026

@ROCm/rocm-devtools-team @ROCm/rocprofiler-owners please review this PR

@afzpatel afzpatel requested a review from bwelton March 3, 2026 18:47
@ammallya ammallya merged commit ef72533 into ROCm:develop Mar 9, 2026
24 of 43 checks passed
@afzpatel afzpatel deleted the add-cpack-component branch March 9, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants