[rocprofiler-sdk] HSA API changes for HSA_AMD_EXT_API_TABLE_STEP_VERSION 0x0A#3823
Merged
venkat1361 merged 10 commits intodevelopfrom Mar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates rocprofiler-sdk’s HSA AMD-EXT API surface to recognize the new HSA_AMD_EXT_API_TABLE_STEP_VERSION 0x0A, keeping API IDs, argument capture, ABI enforcement, and formatting utilities aligned with the updated HSA table.
Changes:
- Adds tracing metadata/plumbing for
hsa_amd_memory_async_batch_copygated onHSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x0A. - Bumps AMD-EXT table ABI version expectations for step
0x0Aand enforces the new function-pointer slot ordering. - Adds
fmtformatters for the newhsa_amd_memory_copy_op_*types (step0x0A).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/hsa.def.cpp | Registers the new AMD-EXT API entry for tracing when step version >= 0x0A |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/details/fmt.hpp | Adds fmt::formatter specializations for new memory copy op types |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/abi.cpp | Updates ABI versioning and function pointer index enforcement for step 0x0A |
| projects/rocprofiler-sdk/source/include/rocprofiler-sdk/hsa/api_args.h | Adds argument-union storage for hsa_amd_memory_async_batch_copy |
| projects/rocprofiler-sdk/source/include/rocprofiler-sdk/hsa/amd_ext_api_id.h | Introduces a new AMD-EXT API ID for hsa_amd_memory_async_batch_copy |
| projects/rocprofiler-sdk/source/include/rocprofiler-sdk/cxx/enum_string.hpp | Adds enum-string label and updates step-version static_assert counts for 0x0A |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/details/fmt.hpp
Outdated
Show resolved
Hide resolved
venkat1361
changed the title
github-actions
bot
added
the
github actions
jrmadsen
previously requested changes
Mar 6, 2026
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/details/fmt.hpp
Outdated
Show resolved
Hide resolved
… reorganize hsa_amd_memory_copy_op_t.
Contributor
Author
|
I have also updated workflows to use cmake 3.24 bc rocprofiler-register requires it from this commit #1243 |
bwelton
approved these changes
Mar 9, 2026
jbonnell-amd
approved these changes
Mar 9, 2026
Collaborator
jbonnell-amd
left a comment
jbonnell-amd
left a comment
There was a problem hiding this comment.
.github/workflows/rocprofiler-sdk-continuous_integration.yml changes look good
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist