[ROCM-1846] Device Metrics Exporter amdsmi CI integration#3848
Open
[ROCM-1846] Device Metrics Exporter amdsmi CI integration#3848
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow to integrate Device Metrics Exporter (DME) validation into the AMDSMI CI pipeline by building AMDSMI from this super-repo, building gpu-agent + DME, and smoke-testing the Prometheus /metrics endpoint.
Changes:
- Introduces a new
.github/workflows/dme-amdsmi-ci.ymlworkflow triggered onprojects/amdsmi/**changes (and manual dispatch). - Builds and installs AMDSMI into
/opt/rocm, then prepares gpu-agent to consume the locally-builtlibamd_smi.so. - Builds gpu-agent and DME, starts both processes, and verifies the metrics endpoint is reachable; uploads logs as artifacts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
070a500 to
71d9b27
Compare
Signed-off-by: yalmusaf <Yazen.ALMusaffar@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
71d9b27 to
775fd10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The purpose of this PR is to have Device Metrics Exporter integrated into amdsmi CI workflow.
Technical Details
Created new file: dme-amdsmi-ci.yml
Inside: rocm-systems/.github/workflows
For DME (Device Metrics Exporter) amdsmi CI integration.
JIRA ID
https://amd-hub.atlassian.net/browse/ROCM-1846
Test Plan
N/A
Test Result
N/A
Submission Checklist
N/A