[rocprofiler-sdk] Add SPM support flag to counter metrics

[SrirakshaNag]

Motivation

Technical Details

JIRA ID

Test Plan

Test Result

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[jrmadsen]

Suggested change

	const auto it = std::find_if(agents.begin(), agents.end(), [&](const auto* agent) {
	const auto itr = std::find_if(agents.begin(), agents.end(), [&](const auto* agent) {

Use itr for consistency with other code.

[jrmadsen]

Move implementation to .cpp file

[jrmadsen]

rename this class to interface or something. In #2706, we will probably just have this point to internal functions (no dlsym).

[jrmadsen]

Suggested change

	class Dlsym
	{
	public:
	using CreateFn = decltype(aqlprofile_spm_create_packets);
	using DeleteFn = decltype(aqlprofile_spm_delete_packets);
	using StartFn = decltype(aqlprofile_spm_start);
	using StopFn = decltype(aqlprofile_spm_stop);
	using DecodeFn = decltype(aqlprofile_spm_decode_stream_v1);
	using QueryFn = decltype(aqlprofile_spm_decode_query);
	using SupportFn = decltype(aqlprofile_spm_is_event_supported);
	Dlsym();
	~Dlsym();
	bool valid() const
	{
	return create_packets_fn != nullptr && delete_packets_fn != nullptr &&
	spm_start_fn != nullptr && spm_stop_fn != nullptr && spm_decode_fn != nullptr &&
	spm_query_fn != nullptr && is_supported_fn != nullptr && handle != nullptr;
	}
	CreateFn* create_packets_fn = nullptr;
	DeleteFn* delete_packets_fn = nullptr;
	StartFn* spm_start_fn = nullptr;
	StopFn* spm_stop_fn = nullptr;
	DecodeFn* spm_decode_fn = nullptr;
	QueryFn* spm_query_fn = nullptr;
	SupportFn* is_supported_fn = nullptr;
	void* handle = nullptr;
	};
	struct spm_interface
	{
	using spm_create_packets_fn_t = decltype(aqlprofile_spm_create_packets);
	// change names below similar to above
	using DeleteFn = decltype(aqlprofile_spm_delete_packets);
	using StartFn = decltype(aqlprofile_spm_start);
	using StopFn = decltype(aqlprofile_spm_stop);
	using DecodeFn = decltype(aqlprofile_spm_decode_stream_v1);
	using QueryFn = decltype(aqlprofile_spm_decode_query);
	using SupportFn = decltype(aqlprofile_spm_is_event_supported);
	spm_create_packets_fn_t* spm_create_packets = nullptr;
	DeleteFn* spm_delete_packets = nullptr;
	StartFn* spm_start = nullptr;
	StopFn* spm_stop = nullptr;
	DecodeFn* spm_decode_stream_v1 = nullptr;
	QueryFn* spm_decode_query = nullptr;
	SupportFn* spm_is_event_supported = nullptr;
	};
	std::optional<spm_interface>
	construct_spm_interface(void* handle = nullptr);

[jrmadsen]

You are using RTLD_NOLOAD, you should not dlclose

[jrmadsen]

You are using RTLD_NOLOAD, you should not dlclose

[jrmadsen]

If the library is expected to be loaded, you can just dlsym(RTLD_DEFAULT, ...)