[rocprofiler-sdk][aqlprofile] Migrate aqlprofile v2 to rocprofiler sdk#4272
Draft
[rocprofiler-sdk][aqlprofile] Migrate aqlprofile v2 to rocprofiler sdk#4272
Conversation
- Copies files over, reorganized, and updated build system
- invoke HSA calls through dispatch table - remove hsa_rsrc_factory unit tests (unnecessary) - fix miscellaneous warnings (NULL -> nullptr, -Wreorder, etc.) - fix miscellaneous header includes
- remove --exclude-header-filter argument from rocprofiler_linting.cmake - update rocprofiler_add_unit_test - LABELS is multi-arg - properly handle disabling - build GoogleMock - Fix LD_LIBRARY_PATH for various tests - add hsa_rsrc_factory_init to registration - prevent segfault in rocprofiler::aql::get_query_info and rocprofiler::aql::get_block_counters - ignore not-visible ROCr devices in aql_helpers unit tests - add rocprofiler::hsa::dlsym_table to construct a dispatch table from dlsym'ing the functions
- missing includes for size_t - handling HSA_AMD_MEMORY_POOL_EXECUTABLE_FLAG when ROCm < 6.3
- prefer ROCP_FATAL_IF instead of assert - fix misc warnings related to implicit conversions
- Mi100Factory does not do certain checks if it is used as a base class.
- implementation suffered from static initialization fiasco
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Opening new PR for #2706 after a rebase.
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist