[DO NOT MERGE] Modify Project Workflows by amd-hsivasun · Pull Request #8 · ROCm/rocm-systems

amd-hsivasun · 2025-07-24T20:09:30Z

No description provided.

github-advanced-security · 2025-07-25T15:18:52Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

ammarwa · 2025-07-25T20:51:29Z

projects/rocprofiler-sdk/.github/workflows/sync-mainline.yaml


 jobs:
  git-mirror:
-    runs-on: AMD-ROCm-Internal-dev1


This file is no longer needed

ammarwa · 2025-07-25T20:51:37Z

projects/rocprofiler-sdk/.github/workflows/sync-staging.yaml


 jobs:
  git-mirror:
-    runs-on: AMD-ROCm-Internal-dev1


This file is no longer needed

ammarwa · 2025-07-25T20:53:42Z

projects/aqlprofile/.github/workflows/codeql.yml

@@ -19,7 +19,7 @@ jobs:
    #   - https://gh.io/supported-runners-and-hardware-resources
    #   - https://gh.io/using-larger-runners (GitHub.com only)
    # Consider using larger runners or machines with greater resources for possible analysis time improvements.


It seems you have CodeQL in the parent Directory, if so and if it checks for CPP, Actions and Python then no need for this file as well

ammarwa · 2025-07-25T20:54:01Z

projects/aqlprofile/.github/workflows/sync-mainline.yaml


 jobs:
  git-mirror:
-    runs-on: AMD-ROCm-Internal-dev1


no need for this file

ammarwa · 2025-07-25T20:54:13Z

projects/aqlprofile/.github/workflows/sync-staging.yaml


 jobs:
  git-mirror:
-    runs-on: AMD-ROCm-Internal-dev1


no need for this file

ammarwa · 2025-07-25T20:54:45Z

projects/rocprofiler-register/.github/workflows/sync-mainline.yaml

 jobs:
  git-mirror:
-    runs-on: AMD-ROCm-Internal-dev1
+    runs-on: ubuntu-latest


no need for this file

ammarwa · 2025-07-25T21:02:24Z

Delete the following workflows as they are not needed anymore:

In AQLProfile:

In ROCProfiler Register:

In ROCProfiler SDK:

…ng-runners

Updating Runners for ROCProfiler

This reverts commit a964aa7.

The target_graphics_version was not formatted properly and was showing incorrect Target Name. Corrected this by fomatting major, minor and revision numbers. Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

Updating README to add a note about doc on rocm.docs portal Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com> Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-register commit: 9338b9a]

Updating README to add a note about doc on rocm.docs portal Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com> Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com> [ROCm/rocprofiler commit: 578db22]

* Rename some examples still using the "omni" prefix. * CMake formatting [ROCm/rocprofiler-systems commit: 656b34b]

The target_graphics_version was not formatted properly and was showing incorrect Target Name. Corrected this by fomatting major, minor and revision numbers. Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com> [ROCm/rocm_smi_lib commit: 94dca70]

The target_graphics_version was not formatted properly and was showing incorrect Target Name. Corrected this by fomatting major, minor and revision numbers. Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com> [ROCm/rocm_smi_lib commit: 6337f7b]

Co-authored-by: rmanocha@amd.com <Dragoslav.Sicarov@amd.com>

[ROCm/rocm-core commit: baedf5d]

Co-authored-by: rmanocha@amd.com <Dragoslav.Sicarov@amd.com> [ROCm/hipother commit: bb66090]

Updated amd-smi set help text --------- Signed-off-by: gabrpham <Gabriel.Pham@amd.com> Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>

Updated amd-smi set help text --------- Signed-off-by: gabrpham <Gabriel.Pham@amd.com> Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com> [ROCm/amdsmi commit: 93a027e]

## Summary - Replace .kpm manifest files with `@GFXARCH@` pattern interpolation in kpack search paths - Fixes wrong-arch manifest bug: each CI shard's .kpm only listed its own architectures (S3 last-writer-wins race caused `hipErrorInvalidImage` at runtime) - Generic artifacts are now truly arch-agnostic (identical regardless of which shard builds them) - Net deletion: 665 lines removed, 78 added ## How it works Instead of: ``` binary → ../.kpack/rand_test.kpm → {arch: "rand_test_gfx1201.kpack"} ``` Now: ``` binary → ../.kpack/rand_test_@GFXARCH@.kpack ``` The C++ runtime (`loader.cpp`) expands `@GFXARCH@` with each requested architecture from the CLR's fallback list, then tries to open the resulting `.kpack` file directly. ## Test plan - [x] Pre-commit passes (all Python checks) - [x] Full kpack test suite: 390 passed, 2 skipped - [x] Real binary split against local build artifacts: `@GFXARCH@` patterns embedded, no .kpm files, ELF verification passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

## Motivation This PR adds entry and exit logs for core functions. ## Technical Details - Info level (3) logs are added at core function entry and exit points. - Monotonic clock stamp, process id, thread id, and file name are added to the logs. - The logs now have similar format to HIP logs for better viewing when both are present. - Direct error or warning logs to std::cerr. Other logs still go to std::cout. ## JIRA ID   ## Test Plan Set env variable ROCDEC_LOG_LEVEL to control log output. All CTests and conformance tests must pass. Example summary of the test results: - CTests: Start 1: video_decodeRaw-HEVC 1/15 Test #1: video_decodeRaw-HEVC ............. Passed 2.05 sec Start 2: video_decodeRaw-AVC 2/15 Test #2: video_decodeRaw-AVC .............. Passed 1.89 sec Start 3: video_decodeRaw-AV1 3/15 Test #3: video_decodeRaw-AV1 .............. Passed 2.31 sec Start 4: video_decodeRaw-VP9 4/15 Test #4: video_decodeRaw-VP9 .............. Passed 2.04 sec Start 5: rocdec_Decode-HEVC 5/15 Test #5: rocdec_Decode-HEVC ............... Passed 0.92 sec Start 6: rocDecode_Negative_API_Tests 6/15 Test #6: rocDecode_Negative_API_Tests ..... Passed 0.78 sec Start 7: video_decode-HEVC 7/15 Test #7: video_decode-HEVC ................ Passed 2.74 sec Start 8: video_decode-AVC 8/15 Test #8: video_decode-AVC ................. Passed 2.64 sec Start 9: video_decode-AV1 9/15 Test #9: video_decode-AV1 ................. Passed 2.74 sec Start 10: video_decode-VP9 10/15 Test #10: video_decode-VP9 ................. Passed 2.78 sec Start 11: video_decodePerf-HEVC 11/15 Test #11: video_decodePerf-HEVC ............ Passed 2.92 sec Start 12: video_decodeBatch 12/15 Test #12: video_decodeBatch ................ Passed 4.34 sec Start 13: video_decodeRGB-HEVC 13/15 Test #13: video_decodeRGB-HEVC ............. Passed 33.51 sec Start 14: video_decodeMem-HEVC 14/15 Test #14: video_decodeMem-HEVC ............. Passed 2.09 sec Start 15: video_decodeRGB-Resize 15/15 Test #15: video_decodeRGB-Resize ........... Passed 33.94 sec 100% tests passed, 0 tests failed out of 15 - AVC conformance test: Conformance test completed on the 127 streams: - The number of passing streams is 127 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - HEVC conformance test: Conformance test completed on the 135 streams: - The number of passing streams is 135 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - AV1 conformance test: Conformance test completed on the 162 streams: - The number of passing streams is 162 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 - VP9 conformance test: Conformance test completed on the 108 streams: - The number of passing streams is 108 - The number of failing streams is 0 - The number of streams that did not finish decoding is 0 ## Test Result Function entry/exit logs should show up when ROCDEC_LOG_LEVEL >= 3. All conformance tests should pass. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Sivasuntharampillai, Haresh added 16 commits July 24, 2025 15:41

Updated Trigger Conditions for Code_Coverage

d441c00

Updated Runner information for all Workflos

04df37a

Refactored RocProfiler-SDK CodeQL

d2ee399

Added Sparse Checkout

519f956

Grab submodules from rocprofiler-sdk

d2932cb

Update Submodules

a413ba9

Moved gitmodules to root

3032583

Update the submodule path of fmt

02ceb6d

Remove fetch for submodules

866cfc4

Added fmt to gitmodules

86c7d01

Added glog to submodules

c75cefc

Added remaining submodules for rocprofiler-sdk

e819aab

Added Filesystem to Submodules

31a8f82

Added remaining submodules

62553a0

Update Requirements File

3efdf53

Updated docs.yml

f8d6fd0

Sivasuntharampillai, Haresh added 6 commits July 25, 2025 12:25

Added Workflows to Sparse Checkout

b285076

Fixed Sparse Checkout

a7114d4

Removed Workflows from checkout

a04cdeb

Checkout specific actions files

c013787

Refactored docs.yml

7856bc7

Update rocprofiler-sdk-docs.yml

c1809fe

ammarwa reviewed Jul 25, 2025

View reviewed changes

Sivasuntharampillai, Haresh and others added 5 commits July 28, 2025 13:58

Removed Unnecessary Workflows

91fefe2

Added RocProfiler-SDK Restrictions

55ef356

Added rocprofiler-sdk Code Coverage

4cff19c

Added rocprofiler-sdk CI Workflow

b2a0a97

Update rocprofiler-sdk-continuous_integration.yml

86ab671

ammarwa added 3 commits July 30, 2025 17:19

Merge branch 'amd/hsivasun/modify-workflows' into amd/aelwazir/updati…

4689af8

…ng-runners

Merge pull request #12 from ROCm/amd/aelwazir/updating-runners

12ab109

Updating Runners for ROCProfiler

Update rocprofiler-sdk-continuous_integration.yml

1f42414

amd-hsivasun merged commit a964aa7 into develop Jul 30, 2025
41 of 51 checks passed

amd-hsivasun added a commit that referenced this pull request Jul 30, 2025

Revert "Modify Project Workflows (#8)"

c05c48a

This reverts commit a964aa7.

amd-hsivasun mentioned this pull request Jul 30, 2025

Revert "[DO NOT MERGE] Modify Project Workflows" #13

Merged

systems-assistant bot pushed a commit that referenced this pull request Aug 5, 2025

Remove rocprofiler-sdk forward decls from public header (#8)

9338b9a

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

systems-assistant bot pushed a commit that referenced this pull request Aug 5, 2025

Create palamida.yml to enable Palamida scan (#8)

baedf5d

jayhawk-commits pushed a commit that referenced this pull request Aug 5, 2025

Remove rocprofiler-sdk forward decls from public header (#8)

cdbb942

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-register commit: 9338b9a]

ammallya pushed a commit that referenced this pull request Aug 6, 2025

Rename some examples still using the "omni" prefix. (#8)

181a782

* Rename some examples still using the "omni" prefix. * CMake formatting [ROCm/rocprofiler-systems commit: 656b34b]

systems-assistant bot mentioned this pull request Aug 7, 2025

[Issue]: hsa_init()/hsa_shut_down() and PAPI rocp_sdk inconsistent behavior #137

Open

systems-assistant bot pushed a commit that referenced this pull request Aug 10, 2025

SWDEV-489106 - Cuda mappings for Linker APIs (#8)

bb66090

Co-authored-by: rmanocha@amd.com <Dragoslav.Sicarov@amd.com>

jayhawk-commits pushed a commit that referenced this pull request Aug 11, 2025

Create palamida.yml to enable Palamida scan (#8)

8e495d0

[ROCm/rocm-core commit: baedf5d]

jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-489106 - Cuda mappings for Linker APIs (#8)

1957322

Co-authored-by: rmanocha@amd.com <Dragoslav.Sicarov@amd.com> [ROCm/hipother commit: bb66090]

jmellorcrummey mentioned this pull request Sep 25, 2025

[Issue]: PC sampling on MI300A eventually dies with an HSA error #1141

Open

ammallya pushed a commit that referenced this pull request Nov 17, 2025

[SWDEV-476303] Exposed valid values for set command (#8)

93a027e

Updated amd-smi set help text --------- Signed-off-by: gabrpham <Gabriel.Pham@amd.com> Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>

systems-assistant bot mentioned this pull request Jan 22, 2026

[Issue]: RCCL is compleatly broken in most configurations #2779

Open

jeffqjiangNew mentioned this pull request Mar 10, 2026

[rocDecode] Add core function entry and exit logs. #3851

Merged

1 task

jeffqjiangNew mentioned this pull request Mar 19, 2026

[rocDecode] Feature: Add support for user set output surface format. #4229

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Modify Project Workflows#8

[DO NOT MERGE] Modify Project Workflows#8
amd-hsivasun merged 56 commits intodevelopfrom
amd/hsivasun/modify-workflows

amd-hsivasun commented Jul 24, 2025

Uh oh!

github-advanced-security bot commented Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Uh oh!

ammarwa commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

amd-hsivasun commented Jul 24, 2025

Uh oh!

github-advanced-security bot commented Jul 25, 2025

Uh oh!

ammarwa Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ammarwa Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ammarwa Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ammarwa Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ammarwa Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ammarwa Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

ammarwa commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants