Code fix for installation by package manager#683
Merged
prbasyal-amd merged 2 commits intoROCm:docs/6.3.0from Apr 29, 2025
Merged
Code fix for installation by package manager#683prbasyal-amd merged 2 commits intoROCm:docs/6.3.0from
prbasyal-amd merged 2 commits intoROCm:docs/6.3.0from
Conversation
prbasyal-amd
force-pushed
the
code-fix-529961-630
branch
from
4d679c0 to
77347ea
Compare
yugang-amd
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
The PR looks good to me, so I approved it.
However I did notice a build failure caused by missing parameters in .readthedocs.yaml. Based on a comparison with the ROCm-internal YAML configuration (https://github.com/ROCm/ROCm-internal/blob/develop/.readthedocs.yaml), I believe adding the following lines to .readthedocs.yaml should resolve the issue:
sphinx:
configuration: docs/conf.py
I can raise a separate PR to address this if needed. Thanks!
For more information about the fix, see https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/
prbasyal-amd
added a commit
to prbasyal-amd/rocprofiler-compute
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager * RTD build error fixed
prbasyal-amd
added a commit
to prbasyal-amd/rocprofiler-compute
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager * RTD build error fixed
prbasyal-amd
added a commit
to prbasyal-amd/rocprofiler-compute
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager * RTD build error fixed
prbasyal-amd
added a commit
to prbasyal-amd/rocprofiler-compute
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager * RTD build error fixed
prbasyal-amd
added a commit
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager (#683)
prbasyal-amd
added a commit
to prbasyal-amd/rocprofiler-compute
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager * RTD build error fixed
prbasyal-amd
added a commit
that referenced
this pull request
Apr 29, 2025
prbasyal-amd
added a commit
that referenced
this pull request
Apr 29, 2025
prbasyal-amd
added a commit
that referenced
this pull request
Apr 29, 2025
* Code fix for installation by package manager (#683)
prbasyal-amd
added a commit
that referenced
this pull request
Apr 30, 2025
* Code fix for installation by package manager * RTD build error fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the following ticket:
https://ontrack-internal.amd.com/browse/SWDEV-529961