Skip to content

Commit bcb3ce5

Browse files
author
Baraldi, Giovanni
authored
Fix for tests. Fix for merge conflict in buffered_output. (#34)
* Fix for tests. Fix for merge conflict in buffered_output. * Formatting --------- Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com> [ROCm/rocprofiler-sdk commit: 4a80ecb]
1 parent 48b686d commit bcb3ce5

File tree

2 files changed

+10
-28
lines changed

2 files changed

+10
-28
lines changed

source/lib/output/buffered_output.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,6 @@ using memory_allocation_buffered_output_t =
158158
domain_type::MEMORY_ALLOCATION>;
159159
using counter_records_buffered_output_t =
160160
::rocprofiler::tool::buffered_output<rocprofiler::tool::serialized_counter_record_t,
161-
domain_type::COUNTER_COLLECTION>;
161+
domain_type::COUNTER_VALUES>;
162162
} // namespace tool
163163
} // namespace rocprofiler

tests/thread-trace/CMakeLists.txt

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -119,20 +119,14 @@ target_sources(
119119
target_link_libraries(thread-trace-api-single-test
120120
PRIVATE rocprofiler-sdk::rocprofiler-sdk amd_comgr dw)
121121

122-
if(ROCPROFILER_MEMCHECK_PRELOAD_ENV)
123-
set(PRELOAD_ENV
124-
"${ROCPROFILER_MEMCHECK_PRELOAD_ENV}:$<TARGET_FILE:thread-trace-api-single-test>")
125-
else()
126-
set(PRELOAD_ENV "LD_PRELOAD=$<TARGET_FILE:thread-trace-api-single-test>")
127-
endif()
128-
129122
add_test(NAME thread-trace-api-single-test
130123
COMMAND $<TARGET_FILE:thread-trace-api-single-test>)
131124

132125
set_tests_properties(
133126
thread-trace-api-single-test
134-
PROPERTIES TIMEOUT 10 LABELS "integration-tests" ENVIRONMENT "${PRELOAD_ENV}"
135-
FAIL_REGULAR_EXPRESSION "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
127+
PROPERTIES TIMEOUT 10 LABELS "integration-tests" ENVIRONMENT
128+
"${ROCPROFILER_MEMCHECK_PRELOAD_ENV}" FAIL_REGULAR_EXPRESSION
129+
"${ROCPROFILER_DEFAULT_FAIL_REGEX}")
136130

137131
# Multi dispatch test
138132
add_executable(thread-trace-api-multi-test)
@@ -142,20 +136,14 @@ target_sources(
142136
target_link_libraries(thread-trace-api-multi-test PRIVATE rocprofiler-sdk::rocprofiler-sdk
143137
amd_comgr dw)
144138

145-
if(ROCPROFILER_MEMCHECK_PRELOAD_ENV)
146-
set(PRELOAD_ENV
147-
"${ROCPROFILER_MEMCHECK_PRELOAD_ENV}:$<TARGET_FILE:thread-trace-api-multi-test>")
148-
else()
149-
set(PRELOAD_ENV "LD_PRELOAD=$<TARGET_FILE:thread-trace-api-multi-test>")
150-
endif()
151-
152139
add_test(NAME thread-trace-api-multi-test
153140
COMMAND $<TARGET_FILE:thread-trace-api-multi-test>)
154141

155142
set_tests_properties(
156143
thread-trace-api-multi-test
157-
PROPERTIES TIMEOUT 10 LABELS "integration-tests" ENVIRONMENT "${PRELOAD_ENV}"
158-
FAIL_REGULAR_EXPRESSION "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
144+
PROPERTIES TIMEOUT 10 LABELS "integration-tests" ENVIRONMENT
145+
"${ROCPROFILER_MEMCHECK_PRELOAD_ENV}" FAIL_REGULAR_EXPRESSION
146+
"${ROCPROFILER_DEFAULT_FAIL_REGEX}")
159147

160148
# Agent profiling test
161149
add_executable(thread-trace-api-agent-test)
@@ -164,17 +152,11 @@ target_sources(thread-trace-api-agent-test PRIVATE agent_test.cpp)
164152
target_link_libraries(thread-trace-api-agent-test
165153
PRIVATE rocprofiler-sdk::rocprofiler-sdk)
166154

167-
if(ROCPROFILER_MEMCHECK_PRELOAD_ENV)
168-
set(PRELOAD_ENV
169-
"${ROCPROFILER_MEMCHECK_PRELOAD_ENV}:$<TARGET_FILE:thread-trace-api-agent-test>")
170-
else()
171-
set(PRELOAD_ENV "LD_PRELOAD=$<TARGET_FILE:thread-trace-api-agent-test>")
172-
endif()
173-
174155
add_test(NAME thread-trace-api-agent-test
175156
COMMAND $<TARGET_FILE:thread-trace-api-agent-test>)
176157

177158
set_tests_properties(
178159
thread-trace-api-agent-test
179-
PROPERTIES TIMEOUT 10 LABELS "integration-tests" ENVIRONMENT "${PRELOAD_ENV}"
180-
FAIL_REGULAR_EXPRESSION "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
160+
PROPERTIES TIMEOUT 10 LABELS "integration-tests" ENVIRONMENT
161+
"${ROCPROFILER_MEMCHECK_PRELOAD_ENV}" FAIL_REGULAR_EXPRESSION
162+
"${ROCPROFILER_DEFAULT_FAIL_REGEX}")

0 commit comments

Comments
 (0)