Skip to content

Add automatic labeling of PRs for peer/2nd review#96

Closed
rocm-devops wants to merge 1 commit intoamd-stagingfrom
bewelton/git_workflow
Closed

Add automatic labeling of PRs for peer/2nd review#96
rocm-devops wants to merge 1 commit intoamd-stagingfrom
bewelton/git_workflow

Conversation

@rocm-devops
Copy link
Copy Markdown

  1. Automatic Label Management:
    - ready for peer review - When PR needs initial review or has changes requested
    - ready for 2nd review - When PR has 1 approval and no changes requested
    - ready for merge - When PR has 2+ approvals and no changes requested
  2. Smart Behavior:
    - Resets to "ready for peer review" when new commits are pushed
    - Ignores reviews from the PR author
    - Only counts the most recent review from each reviewer
    - Automatically creates labels if they don't exist
    - Skips draft PRs
  3. Files Created:
    - .github/workflows/pr-review-label-manager.yml - The main workflow
    - .github/workflows/README.md - Documentation for the workflow

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

Technical details

Added/updated tests?

  • Yes
  • No, Does not apply to this PR.

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

  1. Automatic Label Management:
    - ready for peer review - When PR needs initial review or has changes requested
    - ready for 2nd review - When PR has 1 approval and no changes requested
    - ready for merge - When PR has 2+ approvals and no changes requested
  2. Smart Behavior:
    - Resets to "ready for peer review" when new commits are pushed
    - Ignores reviews from the PR author
    - Only counts the most recent review from each reviewer
    - Automatically creates labels if they don't exist
    - Skips draft PRs
  3. Files Created:
    - .github/workflows/pr-review-label-manager.yml - The main workflow
    - .github/workflows/README.md - Documentation for the workflow
@rocm-devops
Copy link
Copy Markdown
Author

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@jayhawk-commits
Copy link
Copy Markdown
Contributor

Imported to ROCm/rocm-systems.

@amd-hsivasun amd-hsivasun removed the ready for peer review PR needs initial review label Aug 7, 2025
ammallya pushed a commit that referenced this pull request Oct 28, 2025
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: fddd8ac]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants