Skip to content

update scale dot assertion in plot_layout.py #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtang10 wants to merge 1 commit into
base: main_perf
Choose a base branch
from
Open

update scale dot assertion in plot_layout.py #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions python/perf-kernels/tools/plot-layout/plot_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,11 +559,18 @@ def main():
print(f"Plotting dot operation with shapes=M{M}-N{N}-K{K},{kWidth=},{kGroup=},{warpsPerCTA=},{CTAShape=}")
assert M != 0 and CTAShape[0] <= M and M % CTAShape[0] == 0, "bad tensor dimension M"
assert N != 0 and CTAShape[1] <= N and N % CTAShape[1] == 0, "bad tensor dimension N"
assert K != 0, "bad tensor dimension K"
if isMixedPrecBtwF8AndF4OrF6(dtype_a, dtype_b):
## In the case of mixed precision between 8-bit and 4 or 6-bit,
## ignore kWidth and kGroup since inA and inB have different kWidth and kGroup values
kDim = 128
assert K != 0 and K % kDim == 0, f"one mfma instruction requires {kDim:.0f} elements along k dim but BLOCK_K = {K}"
if mfmaNonKDim == 16:
kDim = 128
elif mfmaNonKDim == 32:
kDim = 64
else:
raise NotImplementedError("scaled dot only supports 32x32x64 or 16x16x128 for now")
assert K % kDim == 0, \
f"one mfma instruction requires multiple of {kDim:.0d} elements along k dim but BLOCK_K = {K}"
kpack = 1
CBSZ = matrixFormatTable[dtype_b] if trans else matrixFormatTable[dtype_a]
BLGP = matrixFormatTable[dtype_a] if trans else matrixFormatTable[dtype_b]
Expand All @@ -573,7 +580,7 @@ def main():
plot_scale = scale
else:
kDim = kWidth * kGroup * 64 / mfmaNonKDim
assert K != 0 and K % kDim == 0, f"one mfma instruction requires {kDim:.0f} elements along k dim but BLOCK_K = {K}"
assert K == kDim, f"one mfma instruction requires multiple of {kDim:.0d} elements along k dim but BLOCK_K = {K}"
mfma_inst_str, kpack, CBSZ, BLGP, plot_scale = checkMfmaValidity(mfmaNonKDim, kWidth, kGroup, dtype_a,
dtype_b, trans, scale)
isMixed864 = False
Expand Down