Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new file
fwd_decode_splitk_kvcache-tunning.py, duplicated from06-attention-decode.pyis added in order to benchmark/optimize forward decoder. This script comes with additional heuristics in handling large M edge cases. This script also provides an additional option to bypass using do_bench() function for runtime estimation in order to incorporate with rocprof to accurately estimate the runtime of short running kernels. This script is also ready to provide comparisons with CK once their kernels are implemented (so far, their function call points to an empty kernel, you can see that by doing pytest and you will see 1 failed case).I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end teststhis is only a script for tunning fwd decode kernel.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)