Skip to content

Crash Fix #18127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
freakmaxi wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Crash Fix #18127

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd1013d
as long as "i" is not incremented, the value will be always 0
freakmaxi Jan 29, 2026
b9e8541
Merge branch 'RPCS3:master' into master
freakmaxi Jan 29, 2026
8c2951b
fixed the crash that happens when Allow Host GPU Labels (Experimental…
freakmaxi Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions rpcs3/Emu/RSX/VK/vkutils/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,71 @@ namespace vk
// Useful for debugging different VRAM configurations
const u64 vram_allocation_limit = g_cfg.video.vk.vram_allocation_limit * 0x100000ull;
memory_map.device_local_total_bytes = std::min(memory_map.device_local_total_bytes, vram_allocation_limit);

// Runtime validation for external_memory_host - some drivers advertise but don't fully support it
Copy link
Contributor

@kd-11 kd-11 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a driver bug. Please report to upstream.
For actual internal issues like general incompatibility (quirks) that is handled in rpcs3 layer not the driver wrapper layer. Consider vkuitls to not be part of the emulator if you need a mental model to work with. See VKHelpers and VKGSRender for quirks handling.

  1. https://github.com/RPCS3/rpcs3/blob/master/rpcs3/Emu/RSX/VK/VKGSRender.cpp#L672-L720
  2. https://github.com/RPCS3/rpcs3/blob/master/rpcs3/Emu/RSX/VK/VKHelpers.cpp#L86-L154

Copy link
Contributor

@kd-11 kd-11 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In emergency situations (lets say AMD or NV have a driver regression) we allow turning off the feature on pgpu status and reporting it to the vendor. You can turn off the feature for apple here using a basic preprocessor macro: https://github.com/RPCS3/rpcs3/blob/master/rpcs3/Emu/RSX/VK/vkutils/device.cpp#L123

To clarify - this piece of code here is not correct vulkan behavior by any means. If the spec means nothing we would have to check every extension like this.

if (pgpu->optional_features_support.external_memory_host)
{
bool validation_passed = false;
constexpr usz test_size = 4096;
void* test_ptr = nullptr;

#ifdef _WIN32
test_ptr = _aligned_malloc(test_size, test_size);
#else
if (posix_memalign(&test_ptr, test_size, test_size) != 0)
{
test_ptr = nullptr;
}
#endif

VkBuffer test_buffer = VK_NULL_HANDLE;

if (test_ptr)
{
VkBufferCreateInfo buffer_info{};
buffer_info.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
buffer_info.size = test_size;
buffer_info.usage = VK_BUFFER_USAGE_TRANSFER_SRC_BIT;
buffer_info.sharingMode = VK_SHARING_MODE_EXCLUSIVE;

VkExternalMemoryBufferCreateInfoKHR external_info{};
external_info.sType = VK_STRUCTURE_TYPE_EXTERNAL_MEMORY_BUFFER_CREATE_INFO_KHR;
external_info.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT;
buffer_info.pNext = &external_info;

if (vkCreateBuffer(dev, &buffer_info, nullptr, &test_buffer) == VK_SUCCESS &&
test_buffer != VK_NULL_HANDLE &&
_vkGetMemoryHostPointerPropertiesEXT)
{
VkMemoryHostPointerPropertiesEXT memory_properties{};
memory_properties.sType = VK_STRUCTURE_TYPE_MEMORY_HOST_POINTER_PROPERTIES_EXT;

if (_vkGetMemoryHostPointerPropertiesEXT(dev, VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT, test_ptr, &memory_properties) == VK_SUCCESS &&
memory_properties.memoryTypeBits != 0)
{
validation_passed = true;
rsx_log.notice("VK_EXT_external_memory_host validation passed");
}
}
}

if (test_buffer != VK_NULL_HANDLE)
{
vkDestroyBuffer(dev, test_buffer, nullptr);
}

#ifdef _WIN32
if (test_ptr) _aligned_free(test_ptr);
#else
if (test_ptr) free(test_ptr);
#endif

if (!validation_passed)
{
rsx_log.warning("VK_EXT_external_memory_host validation failed - disabling feature");
pgpu->optional_features_support.external_memory_host = false;
}
}
}

void render_device::destroy()
Expand Down