cellMusicDecode: Do not early out if size_to_read is 0 and the position is POSITION_END#18199
cellMusicDecode: Do not early out if size_to_read is 0 and the position is POSITION_END#18199Megamouse wants to merge 1 commit intoRPCS3:masterfrom
Conversation
|
Happy to help test this in the various EA games. I'm not super experienced compiling builds so if you have one ready it would be a help, but can also tinker with it myself (Windows). |
You can open the PR scroll to the bottom click the checks -> whatever you need Linux, MacOS, Windows. |
|
Hi - was able to test this in NHL Legacy Edition earlier today, same result as before where music wold not play. Log is attached. |
…on is POSITION_END Probably fixes this case: last call: track_fully_decoded == false, size_left == reqSize next call: track_fully_decoded == true, size_left == 0
Probably fixes this case:
last call: track_fully_decoded == false, size_left == reqSize
next call: track_fully_decoded == true, size_left == 0
Maybe fixes #12309