Skip to content

cellMusicDecode: Do not early out if size_to_read is 0 and the position is POSITION_END#18199

Draft
Megamouse wants to merge 1 commit intoRPCS3:masterfrom
Megamouse:gitar
Draft

cellMusicDecode: Do not early out if size_to_read is 0 and the position is POSITION_END#18199
Megamouse wants to merge 1 commit intoRPCS3:masterfrom
Megamouse:gitar

Conversation

@Megamouse
Copy link
Contributor

  • cellMusicDecode: Do not early out if size_to_read is 0 and the position is POSITION_END

Probably fixes this case:
last call: track_fully_decoded == false, size_left == reqSize
next call: track_fully_decoded == true, size_left == 0

Maybe fixes #12309

@sean6on5
Copy link

Happy to help test this in the various EA games. I'm not super experienced compiling builds so if you have one ready it would be a help, but can also tinker with it myself (Windows).

@Darkhost1999
Copy link
Contributor

Happy to help test this in the various EA games. I'm not super experienced compiling builds so if you have one ready it would be a help, but can also tinker with it myself (Windows).

https://wiki.rpcs3.net/index.php?title=Help:Using_different_versions_of_RPCS3#How_to_download_builds_from_a_pull_request_on_GitHub?

You can open the PR scroll to the bottom click the checks -> whatever you need Linux, MacOS, Windows.
Aim for Windows MSVC not clang for now if Windows.
The triple dots will lead you to the log. Then you click summary in the top left corner, scroll down and grab the download button for the build you want to test.

@sean6on5
Copy link

Hi - was able to test this in NHL Legacy Edition earlier today, same result as before where music wold not play. Log is attached.
RPCS3.log.gz
RPCS3.log

@Megamouse Megamouse marked this pull request as draft February 18, 2026 08:06
…on is POSITION_END

Probably fixes this case:
last call: track_fully_decoded == false, size_left == reqSize
next call: track_fully_decoded == true, size_left == 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(NHL 14) Custom cellMusic Only plays once, then LPCM decode failure

3 participants