Merged
Conversation
- OGL desperately needs a functioning DMA layer
- Move some functions to cpp. Makes it easier to debug failing image operations - Add fbo validation before blit operations
… compat is enabled - Renderdoc does not show these calls so we need to insert the debug message
- Allows to transfer partial contents when needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a partial rewrite of DMA interaction. We were actually missing a lot of functionality such as partial transfers and the past few PRs exposed those gaps. I've tested several games and they look correct now, some even better than they ever have. Parity with vulkan is theoretically achieved.
Closes #18156
Closes #18308