fix: Don't try getting node when row/col are negative#57
Open
ixti wants to merge 1 commit intoRRethy:masterfrom
Open
fix: Don't try getting node when row/col are negative#57ixti wants to merge 1 commit intoRRethy:masterfrom
ixti wants to merge 1 commit intoRRethy:masterfrom
Conversation
As of NeoVim 0.11 `get_node` hard enforces row and col to be
non-negative (via assert), that causes endwise fail in those
cases.
```
Error executing vim.schedule lua callback:
/usr/share/nvim/runtime/lua/vim/treesitter.lua:384:
Invalid position: row and col must be non-negative
stack traceback:
[C]: in function 'assert'
/usr/share/nvim/runtime/lua/vim/treesitter.lua:384:
in function 'get_node'
.../nvim-treesitter-endwise/lua/nvim-treesitter/endwise.lua:124:
in function 'endwise'
.../nvim-treesitter-endwise/lua/nvim-treesitter/endwise.lua:216:
in function ''
vim/_editor.lua:
in function <vim/_editor.lua:0>
```
This patch makes it compatible with previous and current version of
NeoVim by exiting early when it's clear that get_node will return nil
(on NeoVim 0.10) or fail (on NeoVim 0.11).
ixti
force-pushed
the
nvim-0-11-compat
branch
from
4784147 to
68313c4
Compare
ixti
added a commit
to ixti/dotfiles
that referenced
this pull request
Dec 5, 2025
|
Thanks for this. Oddly came across this today despite being on tree-sitter |
|
@RRethy - any chance we can get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of NeoVim 0.11
get_nodehard enforces row and col to be non-negative (via assert), that causes endwise fail in those cases:This patch makes it compatible with previous and current version of NeoVim by exiting early when it's clear that get_node will return nil (on NeoVim 0.10) or fail (on NeoVim 0.11).