Open
Conversation
… correctly into crafting module/pipe
bziemons
reviewed
Jul 14, 2025
| // Import (Slots [0, 8]) | ||
| for (Pair<ItemIdentifierStack, Integer> slot : bench.matrix) { | ||
| final int i = slot.getValue2(); | ||
| if (i <= inventory.getSizeInventory() - 2) { |
Member
There was a problem hiding this comment.
not exactly sure why inventory size - 2 would be okay here in the new code, but not previously? Can you elaborate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1720
I'm not quite sure why this code was there in the first place? (The code I've removed)
It seems like you can't manually put recipes that use multiple items/slot into the crafting table, but importing with HEI works just fine, so does the crafting module.
So I guess on another note, it would be nice if inputting recipes like this (into the crafting table) would be possible.