-
Notifications
You must be signed in to change notification settings - Fork 21
Archiving pages #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Archiving pages #964
Conversation
|
I think some pages should still be (easily) accessible. But maybe we can always leave the last one on the collaboration dropdown list. Like the call for proposals ones (at least the last one). For other pages, an archive page linked to in the footer is a good solution! I will try to do this. Agreed that a message at the top of the page with 'Page archived, for your information only' (or something better) would be a good addition. Will add this now. |
ns-rse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moves old pages around fine, but I wonder if we need to add headers to each of the pages to indicate that they are no longer relevant.
E.g. someone navigating to Lunch Bytes might think they are still active based on the text of the page even though the page resides/is linked from the "Archive" menu.
I've had a go at implementing these via #965
This will close #962 which I created the other day.
_data/navigation.yml
Outdated
| subitems: | ||
| - title: RSE Call for proposals 2025 | ||
| url: /collaboration/RSEtime/2025 | ||
| - title: CMI-RSE Projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add in the 2024 call to the archive as it too has passed.
| - title: CMI-RSE Projects | |
| - title: RSE Call for Proposals 2024 | |
| url: /collaboration/RSEtime/2024 | |
| - title: CMI-RSE Projects |
|
@ptheywood I have made the modification you suggested. There is now a link to the Archive page in the "contact" block at the bottom. |
| --- | ||
| title: Testimonials | ||
| permalink: /collaboration/testimonials/ | ||
| permalink: /archive/testimonials/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the permalinks / URLS will cause old links to these pages to break.
As we use github pages, we can't issue header-based 301 redirects, but we have jekyll-redirect-from in the gemfile.
A redirect_from yaml front matter element needs adding to each page which has updated poermalinks, which includes the old-permalink in the redirect_from list (based on our readme)
I.e. for this file it would be
redirect_from:
- /collaboration/testimonials/
I think it's been a while since we used any redirects, so will be worth testing locally before we merge to main (it may need to be /collaboration/testimonials/index.html or similar, not 100%)
ns-rse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't have known about the permalinks issue @ptheywood describes.
Aside from that it looks ready to merge to me.
|
@ptheywood I changed back the permalinks to the original ones, because I could not make the redirect work. But now all the links to the archived pages should work. |
|
I added (and tested) bespoke redirect code months ago: |
|
Thanks @Robadob, the redirect works fine. It is the redirect_from that I have a problem with. |
|
Does look like that plugin is not working for the existing use of Probably worth removing that plugin, and replacing those redirects with Rob's custom one (though it may need tweaking for events?) I'll open an issue. |
|
if that's fine with you @ptheywood and @ns-rse I will merge this. |
ptheywood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the pages being moved to archive/archivedpages/ while the permalinks are still directing to their original location.
This means they will still be indexed by google etc at their original address, but we will have to look for them in the doubly-nested archive directory?
- I.e. why is it
archive/archivedpages/cmi-rse.mdand not justarchive/cmi-rse.md? - If pages are still being served at their original address, why even move the md files?
| directed to the <a href="https://www.sheffield.ac.uk/nap/service/redirect/helpdesks">University IT helpdesk</a>. | ||
| </p> | ||
|
|
||
| <p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This being in the contact include means it will also be in the actual contact page (I think).
Fine for now, but will need moving when the contact section gets ripped out of every page (because it's excessive).
(no need to do anything now)

I simply created an 'Archive' entry in the top bar and moved some pages inside that entry. Based on this from the team work.