Skip to content

Conversation

@Romain-Thomas-Shef
Copy link
Contributor

@Romain-Thomas-Shef Romain-Thomas-Shef commented Dec 23, 2025

I simply created an 'Archive' entry in the top bar and moved some pages inside that entry. Based on this from the team work.

@Romain-Thomas-Shef Romain-Thomas-Shef requested a review from a team December 23, 2025 12:01
@ptheywood
Copy link
Member

I don't think the archive navigation is needed in the top-bar, we don't actually want people going to these pages but just aren't deleting them.
We should probably also make sure that it is clear from the pages that they are archived, using a callout/admonition at the top of the page?

This also causes the navigation bar to drop down below the logo for the md breakpoint.

image

I'm not sure on the best way to link to these archived pages, A new 'archive' page which contains a list of the old pages which is linked to in the footer might be a nicer solution?

@Romain-Thomas-Shef
Copy link
Contributor Author

I think some pages should still be (easily) accessible. But maybe we can always leave the last one on the collaboration dropdown list. Like the call for proposals ones (at least the last one). For other pages, an archive page linked to in the footer is a good solution! I will try to do this.

Agreed that a message at the top of the page with 'Page archived, for your information only' (or something better) would be a good addition. Will add this now.

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves old pages around fine, but I wonder if we need to add headers to each of the pages to indicate that they are no longer relevant.

E.g. someone navigating to Lunch Bytes might think they are still active based on the text of the page even though the page resides/is linked from the "Archive" menu.

I've had a go at implementing these via #965

This will close #962 which I created the other day.

subitems:
- title: RSE Call for proposals 2025
url: /collaboration/RSEtime/2025
- title: CMI-RSE Projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add in the 2024 call to the archive as it too has passed.

Suggested change
- title: CMI-RSE Projects
- title: RSE Call for Proposals 2024
url: /collaboration/RSEtime/2024
- title: CMI-RSE Projects

@Romain-Thomas-Shef
Copy link
Contributor Author

@ptheywood I have made the modification you suggested. There is now a link to the Archive page in the "contact" block at the bottom.
@ns-rse I have put the call 2024 in the archive page. I have moved the 2025 one back to the collaboration menu (with a note that it is closed).

---
title: Testimonials
permalink: /collaboration/testimonials/
permalink: /archive/testimonials/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the permalinks / URLS will cause old links to these pages to break.

As we use github pages, we can't issue header-based 301 redirects, but we have jekyll-redirect-from in the gemfile.

A redirect_from yaml front matter element needs adding to each page which has updated poermalinks, which includes the old-permalink in the redirect_from list (based on our readme)

I.e. for this file it would be

redirect_from:
  - /collaboration/testimonials/

I think it's been a while since we used any redirects, so will be worth testing locally before we merge to main (it may need to be /collaboration/testimonials/index.html or similar, not 100%)

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have known about the permalinks issue @ptheywood describes.

Aside from that it looks ready to merge to me.

@Romain-Thomas-Shef
Copy link
Contributor Author

@ptheywood I changed back the permalinks to the original ones, because I could not make the redirect work. But now all the links to the archived pages should work.

@Robadob
Copy link
Member

Robadob commented Dec 23, 2025

I added (and tested) bespoke redirect code months ago:

#886

@Romain-Thomas-Shef
Copy link
Contributor Author

Thanks @Robadob, the redirect works fine. It is the redirect_from that I have a problem with.

@ptheywood
Copy link
Member

Does look like that plugin is not working for the existing use of _events/, e.g. _events/lunchbytes-2021-07-05.md includes a redirect_from of /events/LunchBytes-2021-07-05.html should mean that https://rse.shef.ac.uk/events/LunchBytes-2021-07-05.html redirects to https://rse.shef.ac.uk/events/lunchbytes-2021-07-05.html, but it instead ends up at https://rse.shef.ac.uk/events/%7B.

Probably worth removing that plugin, and replacing those redirects with Rob's custom one (though it may need tweaking for events?) I'll open an issue.

@Romain-Thomas-Shef
Copy link
Contributor Author

if that's fine with you @ptheywood and @ns-rse I will merge this.

Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the pages being moved to archive/archivedpages/ while the permalinks are still directing to their original location.

This means they will still be indexed by google etc at their original address, but we will have to look for them in the doubly-nested archive directory?

  • I.e. why is it archive/archivedpages/cmi-rse.md and not just archive/cmi-rse.md?
  • If pages are still being served at their original address, why even move the md files?

directed to the <a href="https://www.sheffield.ac.uk/nap/service/redirect/helpdesks">University IT helpdesk</a>.
</p>

<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This being in the contact include means it will also be in the actual contact page (I think).

Fine for now, but will need moving when the contact section gets ripped out of every page (because it's excessive).

(no need to do anything now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants