Skip to content

Update NovelUpdatesBridge.php #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mynacol merged 4 commits into from
Jan 9, 2026
+9 −21
Merged

Update NovelUpdatesBridge.php #4854

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34c7629
Update NovelUpdatesBridge.php
Albirew Dec 31, 2025
2c8176d
Update bridges/NovelUpdatesBridge.php
Albirew Jan 9, 2026
9116941
NovelUpdatesBridge cleanup: removed dirty fix
Albirew Jan 9, 2026
5744b6c
NovelUpdateBridge: Apply suggestions from code review
Albirew Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions bridges/NovelUpdatesBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class NovelUpdatesBridge extends BridgeAbstract
{
const MAINTAINER = 'albirew';
const NAME = 'Novel Updates';
const URI = 'https://www.novelupdates.com/';
const URI = 'https://www.novelupdates.com';
const CACHE_TIMEOUT = 21600; // 6h
const DESCRIPTION = 'Returns releases from Novel Updates';
const PARAMETERS = [ [
Expand All @@ -31,31 +31,19 @@ public function collectData()
$fullhtml = getSimpleHTMLDOM($this->getURI());

$this->seriesTitle = $fullhtml->find('div.seriestitlenu', 0)->plaintext;
// dirty fix for nasty simpledom bug: https://github.com/sebsauvage/rss-bridge/issues/259
// forcefully removes tbody
$html = $fullhtml->find('table#myTable', 0)->innertext;
$html = stristr($html, '<tbody>'); //strip thead
$html = stristr($html, '<tr>'); //remove tbody
$html = str_get_html(stristr($html, '</tbody>', true)); //remove last tbody and get back as an array
$html = $fullhtml->find('table#myTable tbody', 0);
foreach ($html->find('tr') as $element) {
$item = [];
$item['uri'] = $element->find('td', 2)->find('a', 0)->href;
$item['title'] = $element->find('td', 2)->find('a', 0)->plaintext;
$item['team'] = $element->find('td', 1)->innertext;
$item['title'] = $element->find('td', 2)->find('span', 0)->plaintext;
$item['author'] = $element->find('a', 0)->plaintext;
$item['timestamp'] = strtotime($element->find('td', 0)->plaintext);
$item['content'] = '<a href="'
. $item['uri']
. '">'
. $this->seriesTitle
$item['content'] = $this->seriesTitle
. ' - '
. $item['title']
. '</a> by '
. $item['team']
. '<br><a href="'
. $item['uri']
. '">'
. $fullhtml->find('div.seriesimg', 0)->innertext
. '</a>';
. ' - by '
. $item['author']
. '<br>'
. $fullhtml->find('div.seriesimg', 0)->innertext;

$this->items[] = $item;
}
Expand Down