Skip to content

fix: fix lint issues #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: fix lint issues #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
409a69a
fix: remove unused local 'integration_keys'
burib Dec 8, 2023
9e43b6b
fix: remove unused local 'integration_lambda_list'
burib Dec 8, 2023
23e5429
fix: remove unused local 'account_id'
burib Dec 8, 2023
cd09341
fix: fix missing required_version
burib Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions modules/api_gateway/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
locals {
account_id = data.aws_caller_identity.current.account_id
integration_lambda_list = [
for key, value in var.routes :
value["lambda_key"] if lookup(value, "lambda_key", "") != ""
]
integration_keys = {
for k in distinct(local.integration_lambda_list) :
k => ""
}
routes = {
for key, value in var.routes : trimprefix(key, "/") => {
method = lookup(value, "method", "ANY")
Expand Down Expand Up @@ -50,7 +41,6 @@ locals {
}

data "aws_region" "current" {}
data "aws_caller_identity" "current" {}

data "aws_iam_policy_document" "assume_role" {
statement {
Expand Down Expand Up @@ -108,7 +98,7 @@ resource "aws_iam_role_policy" "invocation_policy" {
], [
for key, value in var.lambdas : replace(value.function_arn, "/:\\d+$/", ":*")
])
): e]
) : e]
}
]
})
Expand Down
2 changes: 2 additions & 0 deletions modules/api_gateway/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
terraform {
required_version = ">= 1.0"

required_providers {
aws = {
source = "hashicorp/aws"
Expand Down