chore(shared): gen new hono action field #3961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This chore adds a new filter field entry_attachments_duration to multiple condition schemas and related table definitions so that actions can also filter on attachment durations.
- Extended the Zod enum and TypeScript unions to include
entry_attachments_durationinconditionItemSchemaand variousactionsschemas. - Updated the OpenAPI schemas (
actionsItemOpenAPISchema,actionsOpenAPISchema) and route definitions to recognize the new field. - Adjusted the
actionstable column types to allow the new filter field in database queries.
Comments suppressed due to low confidence (1)
packages/internal/shared/src/hono.ts:461
- Add unit tests for
conditionItemSchema(and related OpenAPI schemas) that validate the newentry_attachments_durationfield, ensuring valid durations pass and invalid inputs are rejected.
field: "title" | "status" | "view" | "site_url" | "feed_url" | "category" | "entry_title" | "entry_content" | "entry_url" | "entry_author" | "entry_media_length" | "entry_attachments_duration";
| declare const languageSchema: z.ZodEnum<["en", "ja", "zh-CN", "zh-TW"]>; | ||
| declare const conditionItemSchema: z.ZodObject<{ | ||
| field: z.ZodEnum<["view", "title", "site_url", "feed_url", "category", "entry_title", "entry_content", "entry_url", "entry_author", "entry_media_length", "status"]>; | ||
| field: z.ZodEnum<["view", "title", "site_url", "feed_url", "category", "entry_title", "entry_content", "entry_url", "entry_author", "entry_media_length", "entry_attachments_duration", "status"]>; |
There was a problem hiding this comment.
[nitpick] The list of valid condition fields is duplicated across dozens of schemas. Consider extracting this array into a shared constant (e.g. const conditionFields = [...]) and referencing it in each ZodEnum to reduce duplication and simplify future updates.
Suggested change
| field: z.ZodEnum<["view", "title", "site_url", "feed_url", "category", "entry_title", "entry_content", "entry_url", "entry_author", "entry_media_length", "entry_attachments_duration", "status"]>; | |
| field: z.ZodEnum<typeof conditionFields>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Type
Screenshots (if UI change)
Demo Video (if new feature)
Linked Issues
Additional context
Changelog