Skip to content

feat(desktop): pass loading prop correctly #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Innei merged 1 commit into from
Jun 30, 2025
Merged

feat(desktop): pass loading prop correctly #4042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/desktop/layer/renderer/src/components/ui/media/PreviewMediaContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ const FallbackableImage: FC<
blurhash?: string
onZoomChange?: (isZoomed: boolean) => void
}
> = ({ src, fallbackUrl, containerClassName, onZoomChange }) => {
> = ({ src, fallbackUrl, containerClassName, onZoomChange, loading }) => {
const [currentSrc, setCurrentSrc] = useState(() => replaceImgUrlIfNeed(src))
const [isAllError, setIsAllError] = useState(false)

Expand Down Expand Up @@ -480,6 +480,7 @@ const FallbackableImage: FC<
maxZoom={2}
src={currentSrc}
alt="preview"
loading={loading}
highResLoaded={!isLoading}
onLoad={() => setIsLoading(false)}
onError={handleError}
Expand Down Expand Up @@ -551,6 +552,7 @@ const DOMImageViewer: FC<{
src: string
alt: string
highResLoaded: boolean
loading?: "lazy" | "eager"
onLoad?: () => void
onError?: () => void
}> = ({
Expand All @@ -562,6 +564,7 @@ const DOMImageViewer: FC<{
src,
alt,
highResLoaded,
loading = "eager",
onLoad,
onError,
}) => {
Expand Down Expand Up @@ -649,7 +652,7 @@ const DOMImageViewer: FC<{
highResLoaded ? "opacity-100" : "opacity-0",
)}
draggable={false}
loading="eager"
loading={loading}
decoding="async"
onLoad={onLoad}
onClick={stopPropagation}
Expand Down
Loading