feat(desktop): improve profile layout #4101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
kovsu
commented
Jul 8, 2025
Comment on lines
+234
to
+237
| // It's a string value when it's from the store | ||
| if (typeof userInfo.socialLinks === "string") { | ||
| userInfo.socialLinks = JSON.parse(userInfo.socialLinks) | ||
| } |
Contributor
|
I think this is not a good design; there is too much white space on the left side. |
Contributor
Author
|
@Innei How about this?
|
Contributor
Looks so good. LGTM |
Innei
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.