Skip to content

fix(mobile): repair discover categories and bootstrap iOS auth#4912

Merged
DIYgod merged 1 commit intodevfrom
codex/mobile-discover-bootstrap-pr
Mar 12, 2026
Merged

fix(mobile): repair discover categories and bootstrap iOS auth#4912
DIYgod merged 1 commit intodevfrom
codex/mobile-discover-bootstrap-pr

Conversation

@DIYgod
Copy link
Member

@DIYgod DIYgod commented Mar 12, 2026

Summary

  • fix mobile discover category requests to match desktop so category pages no longer render empty results
  • add an iOS auth bootstrap helper for simulator self-tests that injects a signed-in session for prod/local runs
  • update the iOS e2e runner and mobile skills/docs to use bootstrap by default for non-auth self-tests on prod/local
  • document Apple Silicon simulator builds to prefer active arm64-only builds for local self-test/e2e runs

Validation

  • pnpm --filter @follow/mobile typecheck
  • sh -n apps/mobile/e2e/run-maestro.sh
  • manual iOS self-test on simulator for discover category pages
  • local/prod bootstrap smoke checks

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9da6a6e432

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +363 to +366
upsertStorageValue(storageDbPath, COOKIE_STORAGE_KEY, JSON.stringify(cookieMap))
upsertStorageValue(storageDbPath, SESSION_TOKEN_STORAGE_KEY, sessionToken)

tryRun("xcrun", ["simctl", "terminate", deviceId, bundleId])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Terminate app before writing ExpoSQLiteStorage

In the new bootstrap flow, the iOS runner launches the app first (apps/mobile/e2e/run-maestro.sh), but this script updates ExpoSQLiteStorage before calling simctl terminate. That ordering means sqlite3 writes can race with the running app’s own SQLite connection and fail with lock errors, which makes pnpm run e2e:ios:bootstrap flaky (especially on slower simulators). Terminating the app before upsertStorageValue(...) (or retrying on busy) avoids these bootstrap failures.

Useful? React with 👍 / 👎.

@DIYgod DIYgod merged commit e8ae098 into dev Mar 12, 2026
13 checks passed
@DIYgod DIYgod deleted the codex/mobile-discover-bootstrap-pr branch March 12, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant