fix(mobile): repair discover categories and bootstrap iOS auth#4912
fix(mobile): repair discover categories and bootstrap iOS auth#4912
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9da6a6e432
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| upsertStorageValue(storageDbPath, COOKIE_STORAGE_KEY, JSON.stringify(cookieMap)) | ||
| upsertStorageValue(storageDbPath, SESSION_TOKEN_STORAGE_KEY, sessionToken) | ||
|
|
||
| tryRun("xcrun", ["simctl", "terminate", deviceId, bundleId]) |
There was a problem hiding this comment.
Terminate app before writing ExpoSQLiteStorage
In the new bootstrap flow, the iOS runner launches the app first (apps/mobile/e2e/run-maestro.sh), but this script updates ExpoSQLiteStorage before calling simctl terminate. That ordering means sqlite3 writes can race with the running app’s own SQLite connection and fail with lock errors, which makes pnpm run e2e:ios:bootstrap flaky (especially on slower simulators). Terminating the app before upsertStorageValue(...) (or retrying on busy) avoids these bootstrap failures.
Useful? React with 👍 / 👎.
Summary
Validation