Skip to content

[action/ci] fix compile error because of arduino package update#10249

Closed
supperthomas wants to merge 1 commit intoRT-Thread:masterfrom
supperthomas:fix
Closed

[action/ci] fix compile error because of arduino package update#10249
supperthomas wants to merge 1 commit intoRT-Thread:masterfrom
supperthomas:fix

Conversation

@supperthomas
Copy link
Copy Markdown
Member

@supperthomas supperthomas commented May 8, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

修复CI编译问题
arduino这个配置维护一个即可。

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@supperthomas supperthomas requested a review from mysterywolf as a code owner May 8, 2025 06:09
@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels May 8, 2025
@supperthomas
Copy link
Copy Markdown
Member Author

@hydevcode ci怎么出错了?

@kurisaW
Copy link
Copy Markdown
Member

kurisaW commented May 8, 2025

@supperthomas arduino那个先不着急移除,这个已经在安排人测试了,后续提交修复PR到RTduino

@supperthomas
Copy link
Copy Markdown
Member Author

@supperthomas arduino那个先不着急移除,这个已经在安排人测试了,后续提交修复PR到RTduino

好的。尽量改成yml吧。还有这个配置只是为了编译,保留一个就行了。

@kurisaW
Copy link
Copy Markdown
Member

kurisaW commented May 8, 2025

好的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants