bsp: gd32470z-lckfb: 增加 SPI Flash 支持及使用说明 #10347
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| * Date Author Notes | ||
| * 2021-12-31 BruceOu first implementation | ||
| * 2023-06-03 CX fixed sf probe error bug | ||
| * 2024-05-30 godmial refactor driver for multi-SPI bus auto-mount | ||
| */ | ||
| #include <board.h> | ||
| #include "drv_spi.h" | ||
|
|
@@ -19,72 +20,101 @@ | |
| #include <rthw.h> | ||
| #include <finsh.h> | ||
|
|
||
| #ifdef RT_USING_DFS | ||
| #include <dfs_fs.h> | ||
| #endif | ||
|
|
||
| struct spi_flash_config | ||
| { | ||
| const char *bus_name; | ||
| const char *device_name; | ||
| const char *flash_name; | ||
| rt_base_t cs_pin; | ||
| }; | ||
|
|
||
| static const struct spi_flash_config flash_configs[] = | ||
| { | ||
| #ifdef BSP_USING_SPI0 | ||
| { | ||
| .bus_name = "spi0", | ||
| .device_name = "spi00", | ||
| .flash_name = "gd25q_spi0", | ||
| .cs_pin = GET_PIN(A, 4), | ||
| }, | ||
| #endif | ||
|
|
||
| #ifdef BSP_USING_SPI1 | ||
| { | ||
| .bus_name = "spi1", | ||
| .device_name = "spi10", | ||
| .flash_name = "gd25q_spi1", | ||
| .cs_pin = GET_PIN(B, 9), | ||
| }, | ||
| #endif | ||
|
|
||
| #ifdef BSP_USING_SPI2 | ||
| { | ||
| .bus_name = "spi2", | ||
| .device_name = "spi20", | ||
| .flash_name = "gd25q_spi2", | ||
| .cs_pin = GET_PIN(B, 12), | ||
| }, | ||
| #endif | ||
|
|
||
| #ifdef BSP_USING_SPI3 | ||
| { | ||
| .bus_name = "spi3", | ||
| .device_name = "spi30", | ||
| .flash_name = "gd25q_spi3", | ||
| .cs_pin = GET_PIN(E, 4), | ||
| }, | ||
| #endif | ||
|
|
||
| #ifdef BSP_USING_SPI4 | ||
| { | ||
| .bus_name = "spi4", | ||
| .device_name = "spi40", | ||
| .flash_name = "gd25qsp", | ||
|
||
| .cs_pin = GET_PIN(F, 6), | ||
| }, | ||
| #endif | ||
| }; | ||
|
|
||
| static int spi_flash_init(void) | ||
| { | ||
| int result = RT_EOK; | ||
|
|
||
| for (size_t i = 0; i < sizeof(flash_configs) / sizeof(flash_configs[0]); i++) | ||
| { | ||
| const struct spi_flash_config *cfg = &flash_configs[i]; | ||
|
|
||
| result = rt_hw_spi_device_attach(cfg->bus_name, cfg->device_name, cfg->cs_pin); | ||
|
There was a problem hiding this comment. The error handling in the for loop overwrites the result from each iteration. Consider aggregating the success state across multiple device attachments or revising the error reporting to ensure that a successful attachment isn't masked by a subsequent failure. |
||
| if (result != RT_EOK) | ||
| { | ||
| rt_kprintf("Failed to attach device %s on bus %s\n", cfg->device_name, cfg->bus_name); | ||
| continue; | ||
| } | ||
|
|
||
| #ifdef RT_USING_SFUD | ||
| if (RT_NULL == rt_sfud_flash_probe(cfg->flash_name, cfg->device_name)) | ||
| { | ||
| rt_kprintf("SFUD probe failed: %s\n", cfg->flash_name); | ||
| continue; | ||
| } | ||
| #endif | ||
|
|
||
| #ifdef RT_USING_DFS | ||
| if (dfs_mount(cfg->flash_name, "/", "elm", 0, 0) == RT_EOK) | ||
|
There was a problem hiding this comment. Mounting all SPI Flash devices to the root directory "/" could lead to conflicts when multiple devices are attached. Consider using unique mount points or a strategy to prevent potential mount point collisions. |
||
| { | ||
| rt_kprintf("SPI flash %s mount success!\n", cfg->flash_name); | ||
| } | ||
| else | ||
| { | ||
| rt_kprintf("SPI flash %s mount failed!\n", cfg->flash_name); | ||
| } | ||
| #endif | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
| INIT_COMPONENT_EXPORT(spi_flash_init); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块格式化有点问题，建议重新刷一下格式