Skip to content

Conversation

@kokorosz
Copy link
Contributor

@kokorosz kokorosz commented Aug 7, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Aug 7, 2025
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f103-blue-pill/README.md
  • bsp/stm32/stm32f103-blue-pill/README_zh.md
  • bsp/stm32/stm32f103-blue-pill/figures/Bluepill_pinout_v2.png

🏷️ Tag: bsp_stm32f103-blue-pill

Reviewers: Liang1795

Changed Files (Click to expand)
  • bsp/stm32/stm32f103-blue-pill/README.md
  • bsp/stm32/stm32f103-blue-pill/README_zh.md
  • bsp/stm32/stm32f103-blue-pill/figures/Bluepill_pinout_v2.png

📊 Current Review Status (Last Updated: 2025-08-07 15:59 CST)

  • Liang1795 Pending Review
  • hamburger-os Pending Review
  • wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666
Copy link
Member

Rbb666 commented Aug 7, 2025

原理图文件不建议提交到主线(占用体积),可以放一个外链到 readme 中,谢谢

@kokorosz
Copy link
Contributor Author

kokorosz commented Aug 7, 2025

从新修改了,从新提交了

@kokorosz
Copy link
Contributor Author

kokorosz commented Aug 7, 2025

原理图文件不建议提交到主线(占用体积),可以放一个外链到 readme 中,谢谢

8b518264e7d1f119d0358c79505a2139 从新上传修改了readme文件了

开发板外观如下图所示:

![board](figures/Bluepill_pinout.png)
![Bluepill_pinout v2](figures\Bluepill_pinout_v2.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该修改为:figures/Bluepill_pinout_v2.png

然后英文的README也帮忙修正下

自查可以看你这边的提交预览:https://github.com/kokorosz/rt-thread/blob/fix-bug/bsp/stm32/stm32f103-blue-pill/README_zh.md

@Rbb666 Rbb666 merged commit 1ce9fa6 into RT-Thread:master Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants