[fix][bsp/renesas][rsoc]: 移除HAL_Drivers/config/ra2a1#10812
[fix][bsp/renesas][rsoc]: 移除HAL_Drivers/config/ra2a1#10812Rbb666 merged 1 commit intoRT-Thread:masterfrom
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_renesasReviewers: kurisaW Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-15 18:04 CST)
📝 Review Instructions
|
|
修改drivers/config/RA8,然后可以把HAL_Drivers/config删掉 |
|
好的 |
|
PR标题修改下,添加上“BSP”/“renesas”关键字,“驱动修改”太过于笼统,需要说清晰修复了什么问题 |
There was a problem hiding this comment.
这些配置文件问啥删除啊?
https://github.com/RT-Thread/rt-thread/tree/master/bsp/renesas/libraries/HAL_Drivers/drivers/config
这些配置文件已经移动到/drivers下
|
LGTM |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
我负责测试瑞萨vision board 上的pwm驱动
在用瑞萨configuration配置GPT12使能,然后在ENV的menuconfig里打开GPT12使能,烧录后会发现找不到PWM12设备,原因是drv_pwm.c文件内对使用PWM宏的定义只定义了BSP_USING_PWM0到BSP_USING_PWM9,同理pwm_config也是如此
你的解决方案是什么 (what is your solution)
这些配置文件已经移动到/drivers下,移除HAL_Drivers/config/ra2a1,在drv_pwm.c和pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up