Skip to content

Conversation

@hzy0117
Copy link
Contributor

@hzy0117 hzy0117 commented Oct 14, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

我负责测试瑞萨vision board 上的pwm驱动
在用瑞萨configuration配置GPT12使能,然后在ENV的menuconfig里打开GPT12使能,烧录后会发现找不到PWM12设备,原因是drv_pwm.c文件内对使用PWM宏的定义只定义了BSP_USING_PWM0到BSP_USING_PWM9,同理pwm_config也是如此

你的解决方案是什么 (what is your solution)

这些配置文件已经移动到/drivers下,移除HAL_Drivers/config/ra2a1,在drv_pwm.c和pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义

请提供验证的bsp和config (provide the config and bsp)

  • BSP:rt-thread\bsp\renesas\libraries
  • .config:无
  • action:无

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ √] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [√ ] 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:pwm_fix
  • 设置PR number为 \ Set the PR number to:10812
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 pwm_fix 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the pwm_fix branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: kurisaW

Changed Files (Click to expand)
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/adc_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/can_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/dac_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/pwm_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/uart_config.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/ra8/pwm_config.h

📊 Current Review Status (Last Updated: 2025-10-15 18:04 CST)

  • kurisaW Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CYFS3
Copy link
Contributor

CYFS3 commented Oct 14, 2025

修改drivers/config/RA8,然后可以把HAL_Drivers/config删掉

@hzy0117
Copy link
Contributor Author

hzy0117 commented Oct 14, 2025

好的

@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 17, 2025
@Rbb666
Copy link
Member

Rbb666 commented Oct 20, 2025

PR标题修改下,添加上“BSP”/“renesas”关键字,“驱动修改”太过于笼统,需要说清晰修复了什么问题

@Rbb666 Rbb666 linked an issue Oct 21, 2025 that may be closed by this pull request
@hzy0117 hzy0117 changed the title fix[rsoc]:PWM驱动修改 [BSP][renesas]fix[rsoc]:PWM驱动修改 Oct 21, 2025
@hzy0117 hzy0117 changed the title [BSP][renesas]fix[rsoc]:PWM驱动修改 [BSP][renesas]fix[rsoc]:PWM通道的宏缺少10-12,新增对PWM10-12宏的定义 Oct 21, 2025
@kurisaW kurisaW changed the title [BSP][renesas]fix[rsoc]:PWM通道的宏缺少10-12,新增对PWM10-12宏的定义 [fix][bsp/renesas][rsoc]: add pwm configuration items Oct 21, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些配置文件问啥删除啊?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些配置文件问啥删除啊?

https://github.com/RT-Thread/rt-thread/tree/master/bsp/renesas/libraries/HAL_Drivers/drivers/config
这些配置文件已经移动到/drivers下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzy0117 那这笔 pr 应该拆出去提交,现在都在一个 pr 里面了

@hzy0117 hzy0117 changed the base branch from master to v5.2.2-beta October 27, 2025 14:05
@hzy0117 hzy0117 changed the title [fix][bsp/renesas][rsoc]: add pwm configuration items [fix][bsp/renesas][rsoc]: 移除HAL_Drivers/config/ra2a1 Oct 27, 2025
@hzy0117 hzy0117 changed the base branch from v5.2.2-beta to master October 28, 2025 05:59
@CYFS3
Copy link
Contributor

CYFS3 commented Oct 28, 2025

LGTM

@Rbb666 Rbb666 merged commit 0017ad1 into RT-Thread:master Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 5.2.2 版本需合并PR汇总

4 participants