-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[clean] Replace deprecated FINSH_FUNCTION_EXPORT macros with MSH_CMD_EXPORT #10843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
1899804
60c9bc2
42aef81
f2d0b8a
af25087
8ef0add
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -182,10 +182,7 @@ void arm_gic_dump(rt_uint32_t index) | |
| } | ||
| rt_kprintf("\n"); | ||
| } | ||
| #ifdef RT_USING_FINSH | ||
| #include <finsh.h> | ||
| FINSH_FUNCTION_EXPORT_ALIAS(arm_gic_dump, gic, show gic status); | ||
| #endif | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 此 pr 请删除类似的多余的换行 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这类是否是要新启一个issue,再推给copilot? @copilot 看看上面回复 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| int arm_gic_dist_init(rt_uint32_t index, rt_uint32_t dist_base, int irq_start) | ||
| { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot
FINSH_FUNCTION_EXPORT_ALIAS调用,统一修改为MSH_CMD_EXPORT进行替换,请注意MSH_CMD_EXPORT的正确使用。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot
FINSH_FUNCTION_EXPORT_ALIAS调用,统一修改为MSH_CMD_EXPORT进行替换,请注意MSH_CMD_EXPORT的正确使用。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
明白了,我会将
FINSH_FUNCTION_EXPORT_ALIAS正确替换为MSH_CMD_EXPORT_ALIAS,保持相同的参数顺序。Understood, I will properly replace
FINSH_FUNCTION_EXPORT_ALIASwithMSH_CMD_EXPORT_ALIAS, maintaining the same parameter order.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已完成,所有 FINSH_FUNCTION_EXPORT_ALIAS 已正确替换为 MSH_CMD_EXPORT_ALIAS,保持相同的参数顺序,commit: f2c36dbb
Completed, all FINSH_FUNCTION_EXPORT_ALIAS properly replaced with MSH_CMD_EXPORT_ALIAS with same parameter order, commit: f2c36dbb