Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 28, 2025

Removes legacy vbus component and associated code. Vbus was an early implementation for RTOS-Linux communication that has been superseded by RPMsg in modern deployments.

Components Removed

  • components/vbus/ - Complete vbus component (1,318 LOC core implementation)
  • libcpu/arm/realview-a8-vmm/ - ARM VMM libcpu support
  • components/Kconfig - Removed vbus rsource reference

BSP Cleanups

bsp/nxp/lpc/lpc43xx/M0/ and M4/

  • Removed vbus driver and configuration files (vbus_drv.c, vbus_hw.h, vbus_conf.h, vbus_local_conf.h)
  • Removed RT_USING_VBUS macro definitions from rtconfig.h
  • Simplified application.c LED thread to toggle locally instead of via vbus communication:
// Before: LED controlled by vbus messages from M4
len = rt_device_read(vbus_dev, 0, &led_value, sizeof(led_value));
led_dev->write(led_dev, 1, &led_value, sizeof(led_value));

// After: LED toggles independently
led_value = !led_value;
led_dev->write(led_dev, 0, &led_value, sizeof(led_value));
rt_thread_delay(1000);

bsp/airm2m/air105/

  • Removed unused rt_vbus_do_init() declaration from board.h

Notes

USB-related "vbus" references (USB VBUS power line detection/control) remain unchanged - they are unrelated to this component.

Total: 43 files changed, 4,537 deletions, 5 insertions

Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature] 移除vbus部分代码及相关的代码</issue_title>
<issue_description>### Describe problem solved by the proposed feature

因为vbus是很早之前实现的代码了,现在在 RTOS + Linux的场合更多使用RPMsg方式,所以移除这部分实现,包括:

  • components/vbus
  • components下的Kconfig的引用;
  • libcpu/arm/realview-a8-vmm 之前使用了vbus的libcpu;

也需要在代码中完整的搜索下,是否有vbus,vmm等相关的代码,如果有相关代码,对这部分代码进行深入分析,以确定是否移除。

Describe your preferred solution

No response

Describe possible alternatives

No response</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Oct 28, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Remove vbus code and related components [Components] Remove vbus component and realview-a8-vmm libcpu Oct 28, 2025
Copilot AI requested a review from BernardXiong October 28, 2025 23:39
Copilot finished work on behalf of BernardXiong October 28, 2025 23:39
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/Kconfig
  • components/vbus/Kconfig
  • components/vbus/SConscript
  • components/vbus/prio_queue.c
  • components/vbus/prio_queue.h
  • components/vbus/share_hdr/vbus_api.h
  • components/vbus/vbus.c
  • components/vbus/vbus.h
  • components/vbus/vbus_chnx.c
  • components/vbus/watermark_queue.c
  • components/vbus/watermark_queue.h

📊 Current Review Status (Last Updated: 2025-10-29 08:11 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@BernardXiong BernardXiong marked this pull request as ready for review October 29, 2025 14:35
@BernardXiong BernardXiong requested a review from Rbb666 as a code owner October 29, 2025 14:35
@BernardXiong BernardXiong added the +1 Agree +1 label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: NXP Code related with NXP BSP Component libcpu +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 移除vbus部分代码及相关的代码

3 participants