Skip to content

Conversation

@weidong-kenny
Copy link
Contributor

@weidong-kenny weidong-kenny commented Jan 4, 2026

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

1、新增 ft32f407xe-starter 板级支持包
2、删除ft32f072xb-starter多余文件

你的解决方案是什么 (what is your solution)

1、在板卡上进行编译无误,测试并通过

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp\ft32\ft32f407xe-starter
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:device
  • 设置PR number为 \ Set the PR number to:11116
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 device 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the device branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2026-01-07 14:13 CST)

  • Rbb666 Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP action github action yml imporve labels Jan 4, 2026
@Rbb666 Rbb666 requested a review from Copilot January 4, 2026 09:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new board support package (BSP) for the FT32F407xE-Starter development board and removes redundant files from the ft32f072xb-starter BSP. The changes include new driver files, CMSIS headers, startup files, and library support for the FT32F4xx series microcontroller.

Reviewed changes

Copilot reviewed 56 out of 149 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
libraries/FT32F4xx/FT32F4xx_Driver/inc/*.h Added peripheral driver header files for FT32F4xx series
libraries/FT32F4xx/CMSIS/FT32F4xx/source/system_ft32f4xx.c Added system initialization and clock configuration
libraries/FT32F4xx/CMSIS/FT32F4xx/source/*/startup_ft32f407xe.s Added startup files for GCC, ARM, and IAR toolchains
libraries/FT32F4xx/CMSIS/FT32F4xx/include/*.h Added CMSIS core headers and device definitions
libraries/Drivers/*.h Updated driver headers to support FT32F4 series
ft32f407xe-starter/board/* Added new BSP board support files
.clang-format-ignore Added FT32F4xx library to format ignore list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关于芯片的底层库函数不建议提交上来了,需要提交到软件包的方式添加了

步骤请参考:rt-thread主仓 BSP瘦身指南

Copy link
Contributor Author

@weidong-kenny weidong-kenny Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边仓库已更新,并已在package仓库提交pr请求,请有时间审核一下,谢谢
pr: RT-Thread/packages#1944

@@ -1,2 +1,3 @@
# clang-format ignore file
/libraries/FT32F0xx/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后续统一使用软件包的形式维护原厂库,所以这里的过滤规则的目录也请删除

@@ -6,5 +6,8 @@ config SOC_SERIES_FT32F0
select ARCH_ARM_CORTEX_M0
select SOC_FAMILY_FT32


config SOC_SERIES_FT32F4
bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F0还有F4请添加对应软件包依赖宏定义

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已添加并删除多余文件

@weidong-kenny
Copy link
Contributor Author

weidong-kenny commented Jan 6, 2026

更新工程中的sconstruct文件导致的编译错误,请再次开启approve流程,谢谢

@kurisaW
Copy link
Member

kurisaW commented Jan 6, 2026

更新工程中的sconstruct文件导致的编译错误,请再次开启approve流程,谢谢

建议可以先本地测试通过,看起来是这个SDK_LIB问题,可以看看其他瘦身的BSP是怎么做的

image

@weidong-kenny
Copy link
Contributor Author

weidong-kenny commented Jan 7, 2026

@kurisaW 请先审核该RT-Thread/packages#1946
再进行一次approve审查,谢谢

本地测试,编译已通过
Snipaste_2026-01-07_09-36-38

@kurisaW
Copy link
Member

kurisaW commented Jan 7, 2026

辛苦作者最后压缩一下提交~

@weidong-kenny
Copy link
Contributor Author

已压缩提交记录,请重新 approve 审查,谢谢

@kurisaW
Copy link
Member

kurisaW commented Jan 8, 2026

你的这份提交有附带其他作者commit,请重新检查

image

@supperthomas
Copy link
Member

PR的标题修改一下建议[bsp/ft32]....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants