Skip to content

Conversation

@polarvid
Copy link
Contributor

@polarvid polarvid commented Nov 19, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Support for ARM64 ASID to enhance virtual memory management efficiency by reducing the need for TLB flushes during address space switches. These changes improve performance especially for multi-process systems.

你的解决方案是什么 (what is your solution)

Changes:

  • Added ARCH_USING_ASID configuration in libcpu/aarch64/Kconfig.
  • Defined ASID-related constants in mmu.h.
  • Updated TLBI_ARG macro to include ASID manipulation.
  • Implemented ASID allocation mechanism with spinlock synchronization.
  • Enhanced TLB invalidation to support ASID-specific operations.
  • Modified rt_hw_aspace_switch to use ASIDs when switching address spaces.
  • Adjusted debug logging and function documentation to reflect ASID usage.
  • Refactored AArch64 MMU and TLB handling for ASID integration.
  • Moved AArch64 architecture configuration to a dedicated Kconfig file.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: QEMU aarch64 virt, RPi4b, rk3568
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Support for ARM64 ASID to enhance virtual memory management efficiency
by reducing the need for TLB flushes during address space switches.
These changes improve performance especially for multi-process systems.

Changes:
- Added `ARCH_USING_ASID` configuration in `libcpu/aarch64/Kconfig`.
- Defined ASID-related constants in `mmu.h`.
- Updated `TLBI_ARG` macro to include ASID manipulation.
- Implemented ASID allocation mechanism with spinlock synchronization.
- Enhanced TLB invalidation to support ASID-specific operations.
- Modified `rt_hw_aspace_switch` to use ASIDs when switching address spaces.
- Adjusted debug logging and function documentation to reflect ASID usage.
- Refactored AArch64 MMU and TLB handling for ASID integration.

Signed-off-by: Shell <[email protected]>
@polarvid polarvid force-pushed the shell/arm64-asid branch 3 times, most recently from 64f8086 to ea277e8 Compare November 19, 2024 11:49
Just for better readability.

Signed-off-by: Shell <[email protected]>
@polarvid polarvid marked this pull request as ready for review November 20, 2024 05:37
@BernardXiong BernardXiong added the +1 Agree +1 label Nov 23, 2024
@mysterywolf mysterywolf merged commit b7520e2 into RT-Thread:master Nov 24, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants