Skip to content

Conversation

@zhangjing0303
Copy link
Contributor

@zhangjing0303 zhangjing0303 commented Nov 20, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

bsp/qemu-virt64-riscv/driver/Kconfig中的BSP_USING_UART1配置没有相应的驱动支持,且qemu中uart不会有PIN的设置,建议删除(该配置与k210 bsp中的BSP_USING_UART1配置完全相同)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/qemu-virt64-riscv
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label Nov 20, 2024
@mysterywolf mysterywolf merged commit 858813a into RT-Thread:master Nov 21, 2024
45 checks passed
@zhangjing0303 zhangjing0303 deleted the rv64_fix_qemu_kconfig branch November 21, 2024 02:51
@unicornx unicornx added the Arch: RISC-V BSP related with risc-v label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants