Skip to content

Conversation

@GorrayLi
Copy link
Contributor

@GorrayLi GorrayLi commented Nov 21, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  1. 为pthread barrier API增加注释;
  2. 修正一些问题:
    1)pthread_barrierattr_setpshared中,将PTHREAD_PROCESS_PRIVATE直接赋值给指针attr,应该赋给*attr。此外,该函数的返回值在任何时候都是EINVAL;
    2)pthread_barrier_destroy函数,在执行destroy前,未检查barrier->count是否为0,即barrier是否仍在使用中。此外,此函数只销毁了barrier中的条件变量cond,而没有销毁mutex。

你的解决方案是什么 (what is your solution)

增加代码以及修正以上问题。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@mysterywolf mysterywolf merged commit bb0a1ea into RT-Thread:master Nov 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants